* [PATCH] phy: bcm-sr-pcie: Change operation when PIPEMUX=1
@ 2019-02-04 19:07 Ray Jui
2019-02-04 19:21 ` Scott Branden
0 siblings, 1 reply; 3+ messages in thread
From: Ray Jui @ 2019-02-04 19:07 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: linux-kernel, bcm-kernel-feedback-list, Qingmin Liu, Ray Jui
From: Qingmin Liu <qingmin.liu@broadcom.com>
When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.
Signed-off-by: Qingmin Liu <qingmin.liu@broadcom.com>
Signed-off-by: Ray Jui <ray.jui@broadcom.com>
---
drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/broadcom/phy-bcm-sr-pcie.c b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
index c10e95f86de5..96a3af126a78 100644
--- a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
+++ b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
@@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
static const u8 pipemux_table[] = {
/* PIPEMUX = 0, EP 1x16 */
0x00,
- /* PIPEMUX = 1, EP 2x8 */
- 0x00,
+ /* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
+ 0x80,
/* PIPEMUX = 2, EP 4x4 */
0x00,
/* PIPEMUX = 3, RC 2x8, cores 0, 7 */
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] phy: bcm-sr-pcie: Change operation when PIPEMUX=1
2019-02-04 19:07 [PATCH] phy: bcm-sr-pcie: Change operation when PIPEMUX=1 Ray Jui
@ 2019-02-04 19:21 ` Scott Branden
2019-02-06 12:16 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 3+ messages in thread
From: Scott Branden @ 2019-02-04 19:21 UTC (permalink / raw)
To: Ray Jui, Kishon Vijay Abraham I
Cc: linux-kernel, bcm-kernel-feedback-list, Qingmin Liu
Looks good.
On 2019-02-04 11:07 a.m., Ray Jui wrote:
> From: Qingmin Liu <qingmin.liu@broadcom.com>
>
> When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.
>
> Signed-off-by: Qingmin Liu <qingmin.liu@broadcom.com>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/broadcom/phy-bcm-sr-pcie.c b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
> index c10e95f86de5..96a3af126a78 100644
> --- a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
> +++ b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
> @@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
> static const u8 pipemux_table[] = {
> /* PIPEMUX = 0, EP 1x16 */
> 0x00,
> - /* PIPEMUX = 1, EP 2x8 */
> - 0x00,
> + /* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
> + 0x80,
> /* PIPEMUX = 2, EP 4x4 */
> 0x00,
> /* PIPEMUX = 3, RC 2x8, cores 0, 7 */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] phy: bcm-sr-pcie: Change operation when PIPEMUX=1
2019-02-04 19:21 ` Scott Branden
@ 2019-02-06 12:16 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2019-02-06 12:16 UTC (permalink / raw)
To: Scott Branden, Ray Jui
Cc: linux-kernel, bcm-kernel-feedback-list, Qingmin Liu
On 05/02/19 12:51 AM, Scott Branden wrote:
> Looks good.
>
> On 2019-02-04 11:07 a.m., Ray Jui wrote:
>> From: Qingmin Liu <qingmin.liu@broadcom.com>
>>
>> When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.
>>
>> Signed-off-by: Qingmin Liu <qingmin.liu@broadcom.com>
>> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
merged, thanks.
-Kishon
>> ---
>> drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> index c10e95f86de5..96a3af126a78 100644
>> --- a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> +++ b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> @@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
>> static const u8 pipemux_table[] = {
>> /* PIPEMUX = 0, EP 1x16 */
>> 0x00,
>> - /* PIPEMUX = 1, EP 2x8 */
>> - 0x00,
>> + /* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
>> + 0x80,
>> /* PIPEMUX = 2, EP 4x4 */
>> 0x00,
>> /* PIPEMUX = 3, RC 2x8, cores 0, 7 */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-06 12:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-04 19:07 [PATCH] phy: bcm-sr-pcie: Change operation when PIPEMUX=1 Ray Jui
2019-02-04 19:21 ` Scott Branden
2019-02-06 12:16 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome