* [PATCH] checkpatch: Fix a typo in the regex for $allocFunctions
@ 2020-04-07 19:00 Christophe JAILLET
2020-04-07 19:03 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2020-04-07 19:00 UTC (permalink / raw)
To: apw, joe; +Cc: linux-kernel, kernel-janitors, Christophe JAILLET
Here, we look for function such as 'netdev_alloc_skb_ip_align', so a '_'
is missing in the regex.
To make sure:
grep -r --include=*.c skbip_a * | wc ==> 0 results
grep -r --include=*.c skb_ip_a * | wc ==> 112 results
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 529c892722b9..c392ab8ea12e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -479,7 +479,7 @@ our $allocFunctions = qr{(?x:
(?:kv|k|v)[czm]alloc(?:_node|_array)? |
kstrdup(?:_const)? |
kmemdup(?:_nul)?) |
- (?:\w+)?alloc_skb(?:ip_align)? |
+ (?:\w+)?alloc_skb(?:_ip_align)? |
# dev_alloc_skb/netdev_alloc_skb, et al
dma_alloc_coherent
)};
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] checkpatch: Fix a typo in the regex for $allocFunctions
2020-04-07 19:00 [PATCH] checkpatch: Fix a typo in the regex for $allocFunctions Christophe JAILLET
@ 2020-04-07 19:03 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2020-04-07 19:03 UTC (permalink / raw)
To: Christophe JAILLET, apw, Andrew Morton; +Cc: linux-kernel, kernel-janitors
On Tue, 2020-04-07 at 21:00 +0200, Christophe JAILLET wrote:
> Here, we look for function such as 'netdev_alloc_skb_ip_align', so a '_'
> is missing in the regex.
>
> To make sure:
> grep -r --include=*.c skbip_a * | wc ==> 0 results
> grep -r --include=*.c skb_ip_a * | wc ==> 112 results
Acked-by: Joe Perches <joe@perches.com>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 529c892722b9..c392ab8ea12e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -479,7 +479,7 @@ our $allocFunctions = qr{(?x:
> (?:kv|k|v)[czm]alloc(?:_node|_array)? |
> kstrdup(?:_const)? |
> kmemdup(?:_nul)?) |
> - (?:\w+)?alloc_skb(?:ip_align)? |
> + (?:\w+)?alloc_skb(?:_ip_align)? |
> # dev_alloc_skb/netdev_alloc_skb, et al
> dma_alloc_coherent
> )};
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-07 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 19:00 [PATCH] checkpatch: Fix a typo in the regex for $allocFunctions Christophe JAILLET
2020-04-07 19:03 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®