From: Ben Hutchings <ben@decadent.org.uk>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: akpm@linux-foundation.org, Denis Kirjanov <kda@linux-powerpc.org>
Subject: [PATCH 3.16 05/10] vxlan: Fix big-endian declaration of VNI
Date: Thu, 09 May 2019 15:08:17 +0100 [thread overview]
Message-ID: <lsq.1557410897.455940790@decadent.org.uk> (raw)
In-Reply-To: <lsq.1557410896.171359878@decadent.org.uk>
3.16.67-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Ben Hutchings <ben@decadent.org.uk>
In this version of the driver, VNIs are consistently kept in host
order. However vxlan_fdb_create() erroneously declares its vni
parameter as __be32, which sparse warns about. Change it to __u32.
This was resolved upstream by commit 54bfd872bf16 "vxlan: keep flags
and vni in network byte order".
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -706,7 +706,7 @@ static struct vxlan_fdb *vxlan_fdb_alloc
static int vxlan_fdb_create(struct vxlan_dev *vxlan,
const u8 *mac, union vxlan_addr *ip,
__u16 state, __be16 port,
- __be32 vni, __u32 ifindex, __u8 ndm_flags,
+ __u32 vni, __u32 ifindex, __u8 ndm_flags,
struct vxlan_fdb **fdb)
{
struct vxlan_rdst *rd = NULL;
next prev parent reply other threads:[~2019-05-09 14:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 14:08 [PATCH 3.16 00/10] 3.16.67-rc1 review Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 04/10] spi: omap-100k: Remove unused definitions Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 10/10] percpu: stop printing kernel addresses Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 09/10] timer/debug: Change /proc/timer_stats from 0644 to 0600 Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 08/10] fork: record start_time late Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 01/10] Revert "brcmfmac: assure SSID length from firmware is limited" Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 02/10] brcmfmac: add length checks in scheduled scan result handler Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 06/10] ipv4: fix a race in update_or_create_fnhe() Ben Hutchings
2019-05-09 14:08 ` Ben Hutchings [this message]
2019-05-09 14:08 ` [PATCH 3.16 07/10] KVM: VMX: Fix x2apic check in vmx_msr_bitmap_mode() Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 03/10] inet: update the IP ID generation algorithm to higher standards Ben Hutchings
2019-05-09 17:38 ` [PATCH 3.16 00/10] 3.16.67-rc1 review Guenter Roeck
2019-05-09 19:00 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lsq.1557410897.455940790@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=akpm@linux-foundation.org \
--cc=kda@linux-powerpc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®