From: Ben Hutchings <ben@decadent.org.uk>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: akpm@linux-foundation.org, Denis Kirjanov <kda@linux-powerpc.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Matteo Croce" <mcroce@redhat.com>,
"Dennis Zhou" <dennis@kernel.org>
Subject: [PATCH 3.16 10/10] percpu: stop printing kernel addresses
Date: Thu, 09 May 2019 15:08:17 +0100 [thread overview]
Message-ID: <lsq.1557410897.661826111@decadent.org.uk> (raw)
In-Reply-To: <lsq.1557410896.171359878@decadent.org.uk>
3.16.67-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Matteo Croce <mcroce@redhat.com>
commit 00206a69ee32f03e6f40837684dcbe475ea02266 upstream.
Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
at boot "____ptrval____" is printed instead of actual addresses:
percpu: Embedded 38 pages/cpu @(____ptrval____) s124376 r0 d31272 u524288
Instead of changing the print to "%px", and leaking kernel addresses,
just remove the print completely, cfr. e.g. commit 071929dbdd865f77
("arm64: Stop printing the virtual memory layout").
Signed-off-by: Matteo Croce <mcroce@redhat.com>
Signed-off-by: Dennis Zhou <dennis@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
mm/percpu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -1716,8 +1716,8 @@ int __init pcpu_embed_first_chunk(size_t
#endif
}
- pr_info("PERCPU: Embedded %zu pages/cpu @%p s%zu r%zu d%zu u%zu\n",
- PFN_DOWN(size_sum), base, ai->static_size, ai->reserved_size,
+ pr_info("PERCPU: Embedded %zu pages/cpu s%zu r%zu d%zu u%zu\n",
+ PFN_DOWN(size_sum), ai->static_size, ai->reserved_size,
ai->dyn_size, ai->unit_size);
rc = pcpu_setup_first_chunk(ai, base);
@@ -1830,8 +1830,8 @@ int __init pcpu_page_first_chunk(size_t
}
/* we're ready, commit */
- pr_info("PERCPU: %d %s pages/cpu @%p s%zu r%zu d%zu\n",
- unit_pages, psize_str, vm.addr, ai->static_size,
+ pr_info("PERCPU: %d %s pages/cpu s%zu r%zu d%zu\n",
+ unit_pages, psize_str, ai->static_size,
ai->reserved_size, ai->dyn_size);
rc = pcpu_setup_first_chunk(ai, vm.addr);
next prev parent reply other threads:[~2019-05-09 14:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 14:08 [PATCH 3.16 00/10] 3.16.67-rc1 review Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 04/10] spi: omap-100k: Remove unused definitions Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 08/10] fork: record start_time late Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 09/10] timer/debug: Change /proc/timer_stats from 0644 to 0600 Ben Hutchings
2019-05-09 14:08 ` Ben Hutchings [this message]
2019-05-09 14:08 ` [PATCH 3.16 07/10] KVM: VMX: Fix x2apic check in vmx_msr_bitmap_mode() Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 05/10] vxlan: Fix big-endian declaration of VNI Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 06/10] ipv4: fix a race in update_or_create_fnhe() Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 01/10] Revert "brcmfmac: assure SSID length from firmware is limited" Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 02/10] brcmfmac: add length checks in scheduled scan result handler Ben Hutchings
2019-05-09 14:08 ` [PATCH 3.16 03/10] inet: update the IP ID generation algorithm to higher standards Ben Hutchings
2019-05-09 17:38 ` [PATCH 3.16 00/10] 3.16.67-rc1 review Guenter Roeck
2019-05-09 19:00 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lsq.1557410897.661826111@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dennis@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kda@linux-powerpc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®