From: ebiederm@xmission.com (Eric W. Biederman)
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>
Subject: [PATCH 4/4] sysfs: Kill nlink counting.
Date: Sun, 18 Dec 2011 20:09:31 -0800 [thread overview]
Message-ID: <m1obv5jj7o.fsf_-_@fess.ebiederm.org> (raw)
In-Reply-To: <m1ty4xjj9r.fsf_-_@fess.ebiederm.org> (Eric W. Biederman's message of "Sun, 18 Dec 2011 20:08:16 -0800")
Tracking the number of subdirectories requires an extra field that increases
the size of sysfs_dirent. nlinks are not particularly interesting for sysfs
and the nlink counts are wrong when network namespaces are involved so stop
counting them, and always return nlink == 1. Userspace already knows that
directories with nlink == 1 have an nlink count they can't use to count
subdirectories.
This reduces the size of sysfs_dirent by 8 bytes on 64bit platforms.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
fs/sysfs/dir.c | 6 ------
fs/sysfs/inode.c | 3 ---
fs/sysfs/sysfs.h | 1 -
3 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
index 0589c9a..ea64d01 100644
--- a/fs/sysfs/dir.c
+++ b/fs/sysfs/dir.c
@@ -91,9 +91,6 @@ static int sysfs_link_sibling(struct sysfs_dirent *sd)
struct rb_node **node = &sd->s_parent->s_dir.children.rb_node;
struct rb_node *parent = NULL;
- if (sysfs_type(sd) == SYSFS_DIR)
- sd->s_parent->s_dir.subdirs++;
-
while (*node) {
struct sysfs_dirent *pos;
int result;
@@ -126,9 +123,6 @@ static int sysfs_link_sibling(struct sysfs_dirent *sd)
*/
static void sysfs_unlink_sibling(struct sysfs_dirent *sd)
{
- if (sysfs_type(sd) == SYSFS_DIR)
- sd->s_parent->s_dir.subdirs--;
-
rb_erase(&sd->s_rb, &sd->s_parent->s_dir.children);
}
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
index c81b22f..c7be716 100644
--- a/fs/sysfs/inode.c
+++ b/fs/sysfs/inode.c
@@ -216,9 +216,6 @@ static void sysfs_refresh_inode(struct sysfs_dirent *sd, struct inode *inode)
iattrs->ia_secdata,
iattrs->ia_secdata_len);
}
-
- if (sysfs_type(sd) == SYSFS_DIR)
- set_nlink(inode, sd->s_dir.subdirs + 2);
}
int sysfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat)
diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h
index 3f23061..2adb052 100644
--- a/fs/sysfs/sysfs.h
+++ b/fs/sysfs/sysfs.h
@@ -19,7 +19,6 @@ struct sysfs_open_dirent;
struct sysfs_elem_dir {
struct kobject *kobj;
- unsigned long subdirs;
/* children rbtree starts here and goes through sd->s_rb */
struct rb_root children;
};
--
1.7.2.5
next prev parent reply other threads:[~2011-12-19 4:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 4:03 [PATCH 0/4] sysfs: Reduce the size of sysfs_dirent Eric W. Biederman
2011-12-19 4:05 ` [PATCH 1/4] sysfs: Add s_hash to sysfs_dirent and order directory entries by hash Eric W. Biederman
2011-12-19 4:07 ` [PATCH 2/4] sysfs: Reduce s_flags to an unsinged short so it packs well with s_mode Eric W. Biederman
2011-12-19 4:08 ` [PATCH 3/4] sysfs: Store the sysfs inode in an unsigned int Eric W. Biederman
2011-12-19 4:09 ` Eric W. Biederman [this message]
2012-01-04 5:43 ` [PATCH 0/4] sysfs: Reduce the size of sysfs_dirent Eric W. Biederman
2012-01-08 17:56 ` Greg KH
2012-01-08 18:15 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1obv5jj7o.fsf_-_@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome