mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>
Subject: [PATCH 2/4] sysfs: Reduce s_flags to an unsinged short so it packs well with s_mode
Date: Sun, 18 Dec 2011 20:07:23 -0800	[thread overview]
Message-ID: <m1zkepjjb8.fsf_-_@fess.ebiederm.org> (raw)
In-Reply-To: <m14nwxkxyg.fsf@fess.ebiederm.org> (Eric W. Biederman's message of "Sun, 18 Dec 2011 20:05:43 -0800")


On 32bit this reduces sizeof(struct sysfs_dirent) by 2 bytes.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 fs/sysfs/sysfs.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h
index 545a8d4..e10ff98 100644
--- a/fs/sysfs/sysfs.h
+++ b/fs/sysfs/sysfs.h
@@ -77,7 +77,7 @@ struct sysfs_dirent {
 		struct sysfs_elem_bin_attr	s_bin_attr;
 	};
 
-	unsigned int		s_flags;
+	unsigned short		s_flags;
 	unsigned short		s_mode;
 	ino_t			s_ino;
 	struct sysfs_inode_attrs *s_iattr;
@@ -94,11 +94,11 @@ struct sysfs_dirent {
 #define SYSFS_ACTIVE_REF		(SYSFS_KOBJ_ATTR | SYSFS_KOBJ_BIN_ATTR)
 
 /* identify any namespace tag on sysfs_dirents */
-#define SYSFS_NS_TYPE_MASK		0xff00
+#define SYSFS_NS_TYPE_MASK		0xf00
 #define SYSFS_NS_TYPE_SHIFT		8
 
 #define SYSFS_FLAG_MASK			~(SYSFS_NS_TYPE_MASK|SYSFS_TYPE_MASK)
-#define SYSFS_FLAG_REMOVED		0x020000
+#define SYSFS_FLAG_REMOVED		0x02000
 
 static inline unsigned int sysfs_type(struct sysfs_dirent *sd)
 {
-- 
1.7.2.5


  reply	other threads:[~2011-12-19  4:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19  4:03 [PATCH 0/4] sysfs: Reduce the size of sysfs_dirent Eric W. Biederman
2011-12-19  4:05 ` [PATCH 1/4] sysfs: Add s_hash to sysfs_dirent and order directory entries by hash Eric W. Biederman
2011-12-19  4:07   ` Eric W. Biederman [this message]
2011-12-19  4:08     ` [PATCH 3/4] sysfs: Store the sysfs inode in an unsigned int Eric W. Biederman
2011-12-19  4:09       ` [PATCH 4/4] sysfs: Kill nlink counting Eric W. Biederman
2012-01-04  5:43 ` [PATCH 0/4] sysfs: Reduce the size of sysfs_dirent Eric W. Biederman
2012-01-08 17:56   ` Greg KH
2012-01-08 18:15     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1zkepjjb8.fsf_-_@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome