mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>
Subject: [PATCH 3/4] sysfs: Store the sysfs inode in an unsigned int.
Date: Sun, 18 Dec 2011 20:08:16 -0800	[thread overview]
Message-ID: <m1ty4xjj9r.fsf_-_@fess.ebiederm.org> (raw)
In-Reply-To: <m1zkepjjb8.fsf_-_@fess.ebiederm.org> (Eric W. Biederman's message of "Sun, 18 Dec 2011 20:07:23 -0800")


Store the sysfs inode number in an unsided int because
ida inode allocator can return at most a 31 bit number,
reducing the size of struct sysfs_dirent by 8 bytes
on 64bit platforms.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 fs/sysfs/dir.c   |    4 ++--
 fs/sysfs/sysfs.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
index 0daf255..0589c9a 100644
--- a/fs/sysfs/dir.c
+++ b/fs/sysfs/dir.c
@@ -224,7 +224,7 @@ static void sysfs_deactivate(struct sysfs_dirent *sd)
 	rwsem_release(&sd->dep_map, 1, _RET_IP_);
 }
 
-static int sysfs_alloc_ino(ino_t *pino)
+static int sysfs_alloc_ino(unsigned int *pino)
 {
 	int ino, rc;
 
@@ -243,7 +243,7 @@ static int sysfs_alloc_ino(ino_t *pino)
 	return rc;
 }
 
-static void sysfs_free_ino(ino_t ino)
+static void sysfs_free_ino(unsigned int ino)
 {
 	spin_lock(&sysfs_ino_lock);
 	ida_remove(&sysfs_ino_ida, ino);
diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h
index e10ff98..3f23061 100644
--- a/fs/sysfs/sysfs.h
+++ b/fs/sysfs/sysfs.h
@@ -79,7 +79,7 @@ struct sysfs_dirent {
 
 	unsigned short		s_flags;
 	unsigned short		s_mode;
-	ino_t			s_ino;
+	unsigned int		s_ino;
 	struct sysfs_inode_attrs *s_iattr;
 };
 
-- 
1.7.2.5


  reply	other threads:[~2011-12-19  4:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19  4:03 [PATCH 0/4] sysfs: Reduce the size of sysfs_dirent Eric W. Biederman
2011-12-19  4:05 ` [PATCH 1/4] sysfs: Add s_hash to sysfs_dirent and order directory entries by hash Eric W. Biederman
2011-12-19  4:07   ` [PATCH 2/4] sysfs: Reduce s_flags to an unsinged short so it packs well with s_mode Eric W. Biederman
2011-12-19  4:08     ` Eric W. Biederman [this message]
2011-12-19  4:09       ` [PATCH 4/4] sysfs: Kill nlink counting Eric W. Biederman
2012-01-04  5:43 ` [PATCH 0/4] sysfs: Reduce the size of sysfs_dirent Eric W. Biederman
2012-01-08 17:56   ` Greg KH
2012-01-08 18:15     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ty4xjj9r.fsf_-_@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome