From: ebiederm@xmission.com (Eric W. Biederman)
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
mingo@elte.hu, linux-kernel@vger.kernel.org,
nanhai.zou@intel.com, asit.k.mallick@intel.com,
keith.packard@intel.com, "Yinghai Lu" <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] x86_64 irq: check remote IRR bit before migrating level triggered irq (v2)
Date: Thu, 31 May 2007 07:29:43 -0600 [thread overview]
Message-ID: <m1y7j53yuw.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <200705311401.02221.ak@suse.de> (Andi Kleen's message of "Thu, 31 May 2007 14:01:02 +0200")
Andi Kleen <ak@suse.de> writes:
> On Thursday 31 May 2007 13:34:21 Eric W. Biederman wrote:
>>
>> On x86_64 kernel, level triggered irq migration gets initiated in the context
>> of that interrupt(after executing the irq handler) and following steps are
>> followed to do the irq migration.
>
> What's the confidence level in the patch? Is it a .22 candidate?
Yes.
I just ran it for a little while and nothing fell over, and level
triggered irqs continued to migrate. So it's not horribly broken.
Outside of implementation errors the worst case that can happen with
this code is the current behavior, with a small slow down.
So since I can not reproduce the original problem I would appreciate
an eyeball or two more just to make certain I reimplemented this
correctly and didn't do anything stupid. But I don't expect anything
to be found. The code is pretty straight forward.
Eric
next prev parent reply other threads:[~2007-05-31 13:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 23:03 [patch] x86_64, irq: check remote IRR bit before migrating level triggered irq Siddha, Suresh B
2007-05-17 23:58 ` Eric W. Biederman
2007-05-18 0:43 ` Siddha, Suresh B
2007-05-18 0:30 ` Eric W. Biederman
2007-05-18 1:01 ` Siddha, Suresh B
2007-05-18 14:40 ` Eric W. Biederman
2007-05-18 17:30 ` Yinghai Lu
2007-05-18 18:01 ` Eric W. Biederman
2007-05-18 18:09 ` Yinghai Lu
2007-05-18 18:20 ` Eric W. Biederman
2007-05-18 18:07 ` Siddha, Suresh B
2007-05-18 18:28 ` Yinghai Lu
2007-05-18 18:39 ` Siddha, Suresh B
2007-05-18 19:02 ` Eric W. Biederman
2007-05-18 19:18 ` Siddha, Suresh B
2007-05-31 2:50 ` Eric W. Biederman
2007-05-18 12:00 ` Andi Kleen
2007-05-18 14:19 ` Eric W. Biederman
2007-05-31 11:34 ` [PATCH] x86_64 irq: check remote IRR bit before migrating level triggered irq (v2) Eric W. Biederman
2007-05-31 12:01 ` Andi Kleen
2007-05-31 13:29 ` Eric W. Biederman [this message]
2007-05-31 20:02 ` Siddha, Suresh B
2007-05-31 13:34 ` Ingo Molnar
2007-05-31 13:50 ` [PATCH] x86_64 irq: check remote IRR bit before migrating level triggered irq (v3) Eric W. Biederman
2007-05-31 13:54 ` Ingo Molnar
2007-05-31 20:00 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1y7j53yuw.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=asit.k.mallick@intel.com \
--cc=keith.packard@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nanhai.zou@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®