* [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
@ 2011-06-21 9:55 James Hogan
2011-06-21 10:17 ` Michał Mirosław
0 siblings, 1 reply; 4+ messages in thread
From: James Hogan @ 2011-06-21 9:55 UTC (permalink / raw)
To: Michał Mirosław, linux-kernel
HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
the CONFIG_ before it when used by the preprocessor.
Signed-off-by: James Hogan <james@albanarts.com>
---
drivers/misc/cb710/sgbuf2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
index d019746..2a40d0e 100644
--- a/drivers/misc/cb710/sgbuf2.c
+++ b/drivers/misc/cb710/sgbuf2.c
@@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
sg_mapping_iter *miter)
static inline bool needs_unaligned_copy(const void *ptr)
{
-#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
+#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
return false;
#else
return ((ptr - NULL) & 3) != 0;
--
1.7.2.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
2011-06-21 9:55 [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS James Hogan
@ 2011-06-21 10:17 ` Michał Mirosław
2011-06-21 16:14 ` Chris Ball
0 siblings, 1 reply; 4+ messages in thread
From: Michał Mirosław @ 2011-06-21 10:17 UTC (permalink / raw)
To: James Hogan; +Cc: linux-kernel, linux-mmc
On Tue, Jun 21, 2011 at 10:55:34AM +0100, James Hogan wrote:
> HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
> the CONFIG_ before it when used by the preprocessor.
>
> Signed-off-by: James Hogan <james@albanarts.com>
> ---
> drivers/misc/cb710/sgbuf2.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
> index d019746..2a40d0e 100644
> --- a/drivers/misc/cb710/sgbuf2.c
> +++ b/drivers/misc/cb710/sgbuf2.c
> @@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
> sg_mapping_iter *miter)
>
> static inline bool needs_unaligned_copy(const void *ptr)
> {
> -#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
> return false;
> #else
> return ((ptr - NULL) & 3) != 0;
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
[Cc: linux-mmc]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
2011-06-21 10:17 ` Michał Mirosław
@ 2011-06-21 16:14 ` Chris Ball
2011-06-21 16:40 ` James Hogan
0 siblings, 1 reply; 4+ messages in thread
From: Chris Ball @ 2011-06-21 16:14 UTC (permalink / raw)
To: Michał Mirosław; +Cc: James Hogan, linux-kernel, linux-mmc
Hi,
On Tue, Jun 21 2011, Michał Mirosław wrote:
> On Tue, Jun 21, 2011 at 10:55:34AM +0100, James Hogan wrote:
>> HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
>> the CONFIG_ before it when used by the preprocessor.
>>
>> Signed-off-by: James Hogan <james@albanarts.com>
>> ---
>> drivers/misc/cb710/sgbuf2.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
>> index d019746..2a40d0e 100644
>> --- a/drivers/misc/cb710/sgbuf2.c
>> +++ b/drivers/misc/cb710/sgbuf2.c
>> @@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
>> sg_mapping_iter *miter)
>>
>> static inline bool needs_unaligned_copy(const void *ptr)
>> {
>> -#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
>> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>> return false;
>> #else
>> return ((ptr - NULL) & 3) != 0;
>
> Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Thanks, pushed to mmc-next for 3.0.
(James, your patch was corrupt due to a hard line break on the @@
line -- please fix that next time around.)
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
2011-06-21 16:14 ` Chris Ball
@ 2011-06-21 16:40 ` James Hogan
0 siblings, 0 replies; 4+ messages in thread
From: James Hogan @ 2011-06-21 16:40 UTC (permalink / raw)
To: Chris Ball; +Cc: Michał Mirosław, linux-kernel, linux-mmc
Hi,
2011/6/21 Chris Ball <cjb@laptop.org>:
> Hi,
>
> On Tue, Jun 21 2011, Michał Mirosław wrote:
>> On Tue, Jun 21, 2011 at 10:55:34AM +0100, James Hogan wrote:
>>> HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
>>> the CONFIG_ before it when used by the preprocessor.
>>>
>>> Signed-off-by: James Hogan <james@albanarts.com>
>>> ---
>>> drivers/misc/cb710/sgbuf2.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
>>> index d019746..2a40d0e 100644
>>> --- a/drivers/misc/cb710/sgbuf2.c
>>> +++ b/drivers/misc/cb710/sgbuf2.c
>>> @@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
>>> sg_mapping_iter *miter)
>>>
>>> static inline bool needs_unaligned_copy(const void *ptr)
>>> {
>>> -#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
>>> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>>> return false;
>>> #else
>>> return ((ptr - NULL) & 3) != 0;
>>
>> Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>
> Thanks, pushed to mmc-next for 3.0.
>
> (James, your patch was corrupt due to a hard line break on the @@
> line -- please fix that next time around.)
Ahh, sorry about that Chris, I thought I had that problem sorted!
Thanks
James
>
> - Chris.
> --
> Chris Ball <cjb@laptop.org> <http://printf.net/>
> One Laptop Per Child
>
--
James Hogan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-21 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-21 9:55 [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS James Hogan
2011-06-21 10:17 ` Michał Mirosław
2011-06-21 16:14 ` Chris Ball
2011-06-21 16:40 ` James Hogan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®