* [PATCH] sound: remove unnecessary blank
@ 2021-03-21 8:59 Fengfei Xi
2021-03-22 11:25 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Fengfei Xi @ 2021-03-21 8:59 UTC (permalink / raw)
To: perex, tiwai; +Cc: alsa-devel, linux-kernel, Fengfei Xi
Remove unnecessary blank when calling kmalloc_array().
Signed-off-by: Fengfei Xi <xi.fengfei@h3c.com>
---
sound/oss/dmasound/dmasound_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c
index 49679aa86..78bb9dfe2 100644
--- a/sound/oss/dmasound/dmasound_core.c
+++ b/sound/oss/dmasound/dmasound_core.c
@@ -421,7 +421,7 @@ static int sq_allocate_buffers(struct sound_queue *sq, int num, int size)
return 0;
sq->numBufs = num;
sq->bufSize = size;
- sq->buffers = kmalloc_array (num, sizeof(char *), GFP_KERNEL);
+ sq->buffers = kmalloc_array(num, sizeof(char *), GFP_KERNEL);
if (!sq->buffers)
return -ENOMEM;
for (i = 0; i < num; i++) {
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] sound: remove unnecessary blank
2021-03-21 8:59 [PATCH] sound: remove unnecessary blank Fengfei Xi
@ 2021-03-22 11:25 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2021-03-22 11:25 UTC (permalink / raw)
To: Fengfei Xi; +Cc: perex, tiwai, alsa-devel, linux-kernel
On Sun, 21 Mar 2021 09:59:48 +0100,
Fengfei Xi wrote:
>
> Remove unnecessary blank when calling kmalloc_array().
>
> Signed-off-by: Fengfei Xi <xi.fengfei@h3c.com>
Thanks for the patch.
We apply this kind of trivial coding-style fix only if it'd improve
the readability significantly or when it's a preliminary work for the
other actual fixes. So if you'd work on this driver further, let us
know.
Takashi
> ---
> sound/oss/dmasound/dmasound_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c
> index 49679aa86..78bb9dfe2 100644
> --- a/sound/oss/dmasound/dmasound_core.c
> +++ b/sound/oss/dmasound/dmasound_core.c
> @@ -421,7 +421,7 @@ static int sq_allocate_buffers(struct sound_queue *sq, int num, int size)
> return 0;
> sq->numBufs = num;
> sq->bufSize = size;
> - sq->buffers = kmalloc_array (num, sizeof(char *), GFP_KERNEL);
> + sq->buffers = kmalloc_array(num, sizeof(char *), GFP_KERNEL);
> if (!sq->buffers)
> return -ENOMEM;
> for (i = 0; i < num; i++) {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-22 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-21 8:59 [PATCH] sound: remove unnecessary blank Fengfei Xi
2021-03-22 11:25 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®