Sound MSI fallout on a Asus mobo NVIDIA MCP55

Sound MSI fallout on a Asus mobo NVIDIA MCP55

[Ralf Gerbig]

Moins,

without the following patch audio ssttuutteerrs on 

ASUS M2N32-SLI PREMIUM ACPI BIOS Revision 1304

the sound device is: 

00:0e.1 Audio device: nVidia Corporation MCP55 High Definition Audio (rev a2)

worked with 2.6.32

--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2351,6 +2351,7 @@
 static struct snd_pci_quirk msi_black_list[] __devinitdata = {
 	SND_PCI_QUIRK(0x1043, 0x81f2, "ASUS", 0), /* Athlon64 X2 + nvidia */
 	SND_PCI_QUIRK(0x1043, 0x81f6, "ASUS", 0), /* nvidia */
+	SND_PCI_QUIRK(0x1043, 0x822d, "ASUS", 0), /* Athlon64 X2 + nvidia MCP55*/
 	{}
 };

if you need it: Signed-off-by: Ralf Gerbig <rge@quengel.org>

Ralf

Re: Sound MSI fallout on a Asus mobo NVIDIA MCP55

[Takashi Iwai]

At Mon, 08 Mar 2010 22:50:08 +0100,
Ralf Gerbig wrote:
> 
> Moins,
> 
> without the following patch audio ssttuutteerrs on 
> 
> ASUS M2N32-SLI PREMIUM ACPI BIOS Revision 1304
> 
> the sound device is: 
> 
> 00:0e.1 Audio device: nVidia Corporation MCP55 High Definition Audio (rev a2)
> 
> worked with 2.6.32

Applied now.
But, at the next time, please submit a patch that can be applied directly.
See Documentation/SubmittingPatches for details.


Thanks.

Takashi


> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2351,6 +2351,7 @@
>  static struct snd_pci_quirk msi_black_list[] __devinitdata = {
>  	SND_PCI_QUIRK(0x1043, 0x81f2, "ASUS", 0), /* Athlon64 X2 + nvidia */
>  	SND_PCI_QUIRK(0x1043, 0x81f6, "ASUS", 0), /* nvidia */
> +	SND_PCI_QUIRK(0x1043, 0x822d, "ASUS", 0), /* Athlon64 X2 + nvidia MCP55*/
>  	{}
>  };
> 
> if you need it: Signed-off-by: Ralf Gerbig <rge@quengel.org>
> 
> Ralf
> 

Re: Sound MSI fallout on a Asus mobo NVIDIA MCP55

[Ralf Gerbig]

Moins,

* Takashi Iwai writes:

> Applied now.
> But, at the next time, please submit a patch that can be applied directly.
> See Documentation/SubmittingPatches for details.

>> --- a/sound/pci/hda/hda_intel.c
>> +++ b/sound/pci/hda/hda_intel.c
>> @@ -2351,6 +2351,7 @@
>> static struct snd_pci_quirk msi_black_list[] __devinitdata = {
>> SND_PCI_QUIRK(0x1043, 0x81f2, "ASUS", 0), /* Athlon64 X2 + nvidia */
>> SND_PCI_QUIRK(0x1043, 0x81f6, "ASUS", 0), /* nvidia */
>> +	SND_PCI_QUIRK(0x1043, 0x822d, "ASUS", 0), /* Athlon64 X2 + nvidia MCP55*/
>> {}
>> };
>> 
>> if you need it: Signed-off-by: Ralf Gerbig <rge@quengel.org>
>> 
>> Ralf
>> 

oops, sorry but I'm not a developer. I did apply this to my tree and
it worked - what went wrong?

thanks,

Ralf

Re: Sound MSI fallout on a Asus mobo NVIDIA MCP55

[Takashi Iwai]

At Tue, 09 Mar 2010 21:30:07 +0100,
Ralf Gerbig wrote:
> 
> Moins,
> 
> * Takashi Iwai writes:
> 
> > Applied now.
> > But, at the next time, please submit a patch that can be applied directly.
> > See Documentation/SubmittingPatches for details.
> 
> >> --- a/sound/pci/hda/hda_intel.c
> >> +++ b/sound/pci/hda/hda_intel.c
> >> @@ -2351,6 +2351,7 @@
> >> static struct snd_pci_quirk msi_black_list[] __devinitdata = {
> >> SND_PCI_QUIRK(0x1043, 0x81f2, "ASUS", 0), /* Athlon64 X2 + nvidia */
> >> SND_PCI_QUIRK(0x1043, 0x81f6, "ASUS", 0), /* nvidia */
> >> +	SND_PCI_QUIRK(0x1043, 0x822d, "ASUS", 0), /* Athlon64 X2 + nvidia MCP55*/
> >> {}
> >> };
> >> 
> >> if you need it: Signed-off-by: Ralf Gerbig <rge@quengel.org>
> >> 
> >> Ralf
> >> 
> 
> oops, sorry but I'm not a developer. I did apply this to my tree and
> it worked - what went wrong?

[dropped stable list]

It's just about the patch file format.  The change you made is fine.

If the patch is posted in a format described in SubmittingPatches, we
can apply it directly with git-am without modifying much.  Otherwise,
manual editing is needed, and this might introduce unnecessary
cut&paste errors.


thanks,

Takashi