From: Takashi Iwai <tiwai@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Paul Collins <paul@briny.ondioline.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [Alsa-devel] all-modular snd-aoa
Date: Fri, 23 Jun 2006 16:50:49 +0200 [thread overview]
Message-ID: <s5h3bdw9b92.wl%tiwai@suse.de> (raw)
In-Reply-To: <1151073390.7608.38.camel@localhost>
At Fri, 23 Jun 2006 16:36:30 +0200,
Johannes Berg wrote:
>
> On Fri, 2006-06-23 at 16:30 +0200, Takashi Iwai wrote:
>
> > Where is the problem in Makefile? It looks OK to me...
>
> Well, the problem is the fact the snd-aoa/ dir contains nothing to be
> compiled and the kernel Makefiles don't like that.
Then it's eaiser to fix sound/Makefile.
--- a/sound/Makefile Fri Jun 23 15:18:41 2006 +0200
+++ b/sound/Makefile Fri Jun 23 16:49:15 2006 +0200
@@ -4,7 +4,8 @@ obj-$(CONFIG_SOUND) += soundcore.o
obj-$(CONFIG_SOUND) += soundcore.o
obj-$(CONFIG_SOUND_PRIME) += oss/
obj-$(CONFIG_DMASOUND) += oss/
-obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ aoa/
+obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/
+obj-$(CONFIG_SND_AOA) += aoa/
ifeq ($(CONFIG_SND),y)
obj-y += last.o
> > Nevertheless, aoa/Kconfig has a wrong dependency on SND_PCM.
>
> Good point. Committing to my repository, how should we process things
> like that now? Should I post some patches once a while or do you want to
> commit that right away?
Post patches to alsa-devel (and Cc to me). Will be pushed together
with other fixes.
Takashi
next prev parent reply other threads:[~2006-06-23 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 9:14 Paul Collins
2006-06-23 14:14 ` Johannes Berg
2006-06-23 14:30 ` [Alsa-devel] " Takashi Iwai
2006-06-23 14:36 ` Johannes Berg
2006-06-23 14:50 ` Takashi Iwai [this message]
2006-06-23 14:54 ` Johannes Berg
2006-06-23 15:00 ` Takashi Iwai
2006-06-23 15:03 ` Johannes Berg
2006-06-23 15:07 ` Paul Collins
2006-06-26 6:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h3bdw9b92.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@briny.ondioline.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome