Re: [Alsa-devel] all-modular snd-aoa

[Takashi Iwai <tiwai@suse.de>]

At Fri, 23 Jun 2006 16:14:55 +0200,
Johannes Berg wrote:
> 
> On Fri, 2006-06-23 at 19:14 +1000, Paul Collins wrote:
> > I get this when building from Linus's current git tree:
> > 
> >     LD      sound/built-in.o
> >   ld: sound/aoa/built-in.o: No such file: No such file or directory
> >   make[1]: *** [sound/built-in.o] Error 1
> >   make: *** [sound] Error 2
> > 
> > Doing "touch sound/aoa/built-in.o" lets the build continue and
> > complete successfully.
> 
> Ahrg! That's a mistake in my Makefile programming, I'll probably have to
> move the core/ files up one dir. Sorry.

Where is the problem in Makefile?  It looks OK to me...

Nevertheless, aoa/Kconfig has a wrong dependency on SND_PCM.


Takashi

--- a/sound/aoa/Kconfig	Fri Jun 23 15:18:41 2006 +0200
+++ b/sound/aoa/Kconfig	Fri Jun 23 16:29:14 2006 +0200
@@ -3,7 +3,8 @@ menu "Apple Onboard Audio driver"
 
 config SND_AOA
 	tristate "Apple Onboard Audio driver"
-	depends on SOUND && SND_PCM
+	depends on SND
+	select SND_PCM
 	---help---
 	This option enables the new driver for the various
 	Apple Onboard Audio components.