From: Takashi Iwai <tiwai@suse.de>
To: "Colin King" <colin.king@canonical.com>
Cc: <alsa-devel@alsa-project.org>, "Jeeja KP" <jeeja.kp@intel.com>,
"Subhransu S . Prusty" <subhransu.s.prusty@intel.com>,
"Vinod Koul" <vinod.koul@intel.com>,
"Mark Brown" <broonie@kernel.org>, <trivial@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hdac: add missing \n to end of dev_err messages
Date: Fri, 16 Sep 2016 19:24:54 +0200 [thread overview]
Message-ID: <s5h4m5foizd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160916163605.11615-1-colin.king@canonical.com>
On Fri, 16 Sep 2016 18:36:05 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, some dev_err messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
> ---
> sound/hda/ext/hdac_ext_stream.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/sound/hda/ext/hdac_ext_stream.c b/sound/hda/ext/hdac_ext_stream.c
> index 2441273..3be051a 100644
> --- a/sound/hda/ext/hdac_ext_stream.c
> +++ b/sound/hda/ext/hdac_ext_stream.c
> @@ -424,7 +424,7 @@ void snd_hdac_ext_stream_spbcap_enable(struct hdac_ext_bus *ebus,
> struct hdac_bus *bus = &ebus->bus;
>
> if (!bus->spbcap) {
> - dev_err(bus->dev, "Address of SPB capability is NULL");
> + dev_err(bus->dev, "Address of SPB capability is NULL\n");
> return;
> }
>
> @@ -453,7 +453,7 @@ int snd_hdac_ext_stream_set_spib(struct hdac_ext_bus *ebus,
> struct hdac_bus *bus = &ebus->bus;
>
> if (!bus->spbcap) {
> - dev_err(bus->dev, "Address of SPB capability is NULL");
> + dev_err(bus->dev, "Address of SPB capability is NULL\n");
> return -EINVAL;
> }
>
> @@ -476,7 +476,7 @@ int snd_hdac_ext_stream_get_spbmaxfifo(struct hdac_ext_bus *ebus,
> struct hdac_bus *bus = &ebus->bus;
>
> if (!bus->spbcap) {
> - dev_err(bus->dev, "Address of SPB capability is NULL");
> + dev_err(bus->dev, "Address of SPB capability is NULL\n");
> return -EINVAL;
> }
>
> @@ -516,7 +516,7 @@ void snd_hdac_ext_stream_drsm_enable(struct hdac_ext_bus *ebus,
> struct hdac_bus *bus = &ebus->bus;
>
> if (!bus->drsmcap) {
> - dev_err(bus->dev, "Address of DRSM capability is NULL");
> + dev_err(bus->dev, "Address of DRSM capability is NULL\n");
> return;
> }
>
> @@ -545,7 +545,7 @@ int snd_hdac_ext_stream_set_dpibr(struct hdac_ext_bus *ebus,
> struct hdac_bus *bus = &ebus->bus;
>
> if (!bus->drsmcap) {
> - dev_err(bus->dev, "Address of DRSM capability is NULL");
> + dev_err(bus->dev, "Address of DRSM capability is NULL\n");
> return -EINVAL;
> }
>
> --
> 2.9.3
>
>
prev parent reply other threads:[~2016-09-16 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 16:36 Colin King
2016-09-16 17:24 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4m5foizd.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=jeeja.kp@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=subhransu.s.prusty@intel.com \
--cc=trivial@kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®