* [PATCH] ALSA: hdac: add missing \n to end of dev_err messages
@ 2016-09-16 16:36 Colin King
2016-09-16 17:24 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-09-16 16:36 UTC (permalink / raw)
To: trivial, Jaroslav Kysela, Takashi Iwai, Vinod Koul, Jeeja KP,
Mark Brown, Subhransu S . Prusty, alsa-devel
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trival fix, some dev_err messages are missing a \n, so add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/hda/ext/hdac_ext_stream.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/hda/ext/hdac_ext_stream.c b/sound/hda/ext/hdac_ext_stream.c
index 2441273..3be051a 100644
--- a/sound/hda/ext/hdac_ext_stream.c
+++ b/sound/hda/ext/hdac_ext_stream.c
@@ -424,7 +424,7 @@ void snd_hdac_ext_stream_spbcap_enable(struct hdac_ext_bus *ebus,
struct hdac_bus *bus = &ebus->bus;
if (!bus->spbcap) {
- dev_err(bus->dev, "Address of SPB capability is NULL");
+ dev_err(bus->dev, "Address of SPB capability is NULL\n");
return;
}
@@ -453,7 +453,7 @@ int snd_hdac_ext_stream_set_spib(struct hdac_ext_bus *ebus,
struct hdac_bus *bus = &ebus->bus;
if (!bus->spbcap) {
- dev_err(bus->dev, "Address of SPB capability is NULL");
+ dev_err(bus->dev, "Address of SPB capability is NULL\n");
return -EINVAL;
}
@@ -476,7 +476,7 @@ int snd_hdac_ext_stream_get_spbmaxfifo(struct hdac_ext_bus *ebus,
struct hdac_bus *bus = &ebus->bus;
if (!bus->spbcap) {
- dev_err(bus->dev, "Address of SPB capability is NULL");
+ dev_err(bus->dev, "Address of SPB capability is NULL\n");
return -EINVAL;
}
@@ -516,7 +516,7 @@ void snd_hdac_ext_stream_drsm_enable(struct hdac_ext_bus *ebus,
struct hdac_bus *bus = &ebus->bus;
if (!bus->drsmcap) {
- dev_err(bus->dev, "Address of DRSM capability is NULL");
+ dev_err(bus->dev, "Address of DRSM capability is NULL\n");
return;
}
@@ -545,7 +545,7 @@ int snd_hdac_ext_stream_set_dpibr(struct hdac_ext_bus *ebus,
struct hdac_bus *bus = &ebus->bus;
if (!bus->drsmcap) {
- dev_err(bus->dev, "Address of DRSM capability is NULL");
+ dev_err(bus->dev, "Address of DRSM capability is NULL\n");
return -EINVAL;
}
--
2.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hdac: add missing \n to end of dev_err messages
2016-09-16 16:36 [PATCH] ALSA: hdac: add missing \n to end of dev_err messages Colin King
@ 2016-09-16 17:24 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-09-16 17:24 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, Jeeja KP, Subhransu S . Prusty, Vinod Koul,
Mark Brown, trivial, Jaroslav Kysela, linux-kernel
On Fri, 16 Sep 2016 18:36:05 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, some dev_err messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
> ---
> sound/hda/ext/hdac_ext_stream.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/sound/hda/ext/hdac_ext_stream.c b/sound/hda/ext/hdac_ext_stream.c
> index 2441273..3be051a 100644
> --- a/sound/hda/ext/hdac_ext_stream.c
> +++ b/sound/hda/ext/hdac_ext_stream.c
> @@ -424,7 +424,7 @@ void snd_hdac_ext_stream_spbcap_enable(struct hdac_ext_bus *ebus,
> struct hdac_bus *bus = &ebus->bus;
>
> if (!bus->spbcap) {
> - dev_err(bus->dev, "Address of SPB capability is NULL");
> + dev_err(bus->dev, "Address of SPB capability is NULL\n");
> return;
> }
>
> @@ -453,7 +453,7 @@ int snd_hdac_ext_stream_set_spib(struct hdac_ext_bus *ebus,
> struct hdac_bus *bus = &ebus->bus;
>
> if (!bus->spbcap) {
> - dev_err(bus->dev, "Address of SPB capability is NULL");
> + dev_err(bus->dev, "Address of SPB capability is NULL\n");
> return -EINVAL;
> }
>
> @@ -476,7 +476,7 @@ int snd_hdac_ext_stream_get_spbmaxfifo(struct hdac_ext_bus *ebus,
> struct hdac_bus *bus = &ebus->bus;
>
> if (!bus->spbcap) {
> - dev_err(bus->dev, "Address of SPB capability is NULL");
> + dev_err(bus->dev, "Address of SPB capability is NULL\n");
> return -EINVAL;
> }
>
> @@ -516,7 +516,7 @@ void snd_hdac_ext_stream_drsm_enable(struct hdac_ext_bus *ebus,
> struct hdac_bus *bus = &ebus->bus;
>
> if (!bus->drsmcap) {
> - dev_err(bus->dev, "Address of DRSM capability is NULL");
> + dev_err(bus->dev, "Address of DRSM capability is NULL\n");
> return;
> }
>
> @@ -545,7 +545,7 @@ int snd_hdac_ext_stream_set_dpibr(struct hdac_ext_bus *ebus,
> struct hdac_bus *bus = &ebus->bus;
>
> if (!bus->drsmcap) {
> - dev_err(bus->dev, "Address of DRSM capability is NULL");
> + dev_err(bus->dev, "Address of DRSM capability is NULL\n");
> return -EINVAL;
> }
>
> --
> 2.9.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-16 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 16:36 [PATCH] ALSA: hdac: add missing \n to end of dev_err messages Colin King
2016-09-16 17:24 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®