* [PATCH] ALSA: cs5535audio: constify cs5535audio_dma_ops structures
@ 2015-12-30 10:44 Julia Lawall
2015-12-30 21:51 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2015-12-30 10:44 UTC (permalink / raw)
To: Jaya Kumar
Cc: kernel-janitors, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
The cs5535audio_dma_ops structures are never modified, so declare them as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
sound/pci/cs5535audio/cs5535audio_pcm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/cs5535audio/cs5535audio_pcm.c b/sound/pci/cs5535audio/cs5535audio_pcm.c
index 9c2dc91..27fa57d 100644
--- a/sound/pci/cs5535audio/cs5535audio_pcm.c
+++ b/sound/pci/cs5535audio/cs5535audio_pcm.c
@@ -402,7 +402,7 @@ static struct snd_pcm_ops snd_cs5535audio_capture_ops = {
.pointer = snd_cs5535audio_pcm_pointer,
};
-static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
+static const struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
.type = CS5535AUDIO_DMA_PLAYBACK,
.enable_dma = cs5535audio_playback_enable_dma,
.disable_dma = cs5535audio_playback_disable_dma,
@@ -412,7 +412,7 @@ static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
.read_dma_pntr = cs5535audio_playback_read_dma_pntr,
};
-static struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = {
+static const struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = {
.type = CS5535AUDIO_DMA_CAPTURE,
.enable_dma = cs5535audio_capture_enable_dma,
.disable_dma = cs5535audio_capture_disable_dma,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: cs5535audio: constify cs5535audio_dma_ops structures
2015-12-30 10:44 [PATCH] ALSA: cs5535audio: constify cs5535audio_dma_ops structures Julia Lawall
@ 2015-12-30 21:51 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2015-12-30 21:51 UTC (permalink / raw)
To: Julia Lawall
Cc: Jaya Kumar, alsa-devel, Jaroslav Kysela, kernel-janitors, linux-kernel
On Wed, 30 Dec 2015 11:44:53 +0100,
Julia Lawall wrote:
>
> The cs5535audio_dma_ops structures are never modified, so declare them as
> const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied, thanks.
Takashi
>
> ---
> sound/pci/cs5535audio/cs5535audio_pcm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/cs5535audio/cs5535audio_pcm.c b/sound/pci/cs5535audio/cs5535audio_pcm.c
> index 9c2dc91..27fa57d 100644
> --- a/sound/pci/cs5535audio/cs5535audio_pcm.c
> +++ b/sound/pci/cs5535audio/cs5535audio_pcm.c
> @@ -402,7 +402,7 @@ static struct snd_pcm_ops snd_cs5535audio_capture_ops = {
> .pointer = snd_cs5535audio_pcm_pointer,
> };
>
> -static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
> +static const struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
> .type = CS5535AUDIO_DMA_PLAYBACK,
> .enable_dma = cs5535audio_playback_enable_dma,
> .disable_dma = cs5535audio_playback_disable_dma,
> @@ -412,7 +412,7 @@ static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
> .read_dma_pntr = cs5535audio_playback_read_dma_pntr,
> };
>
> -static struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = {
> +static const struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = {
> .type = CS5535AUDIO_DMA_CAPTURE,
> .enable_dma = cs5535audio_capture_enable_dma,
> .disable_dma = cs5535audio_capture_disable_dma,
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-30 21:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-30 10:44 [PATCH] ALSA: cs5535audio: constify cs5535audio_dma_ops structures Julia Lawall
2015-12-30 21:51 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®