* [PATCH][next] ALSA: xen-front: remove redundant error check on ret
@ 2018-05-27 21:23 Colin King
2018-05-27 22:42 ` Takashi Sakamoto
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-05-27 21:23 UTC (permalink / raw)
To: Oleksandr Andrushchenko, Jaroslav Kysela, Takashi Iwai,
xen-devel, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The error for a -ve value in ret is redundant as all previous
assignments to ret have an associated -ve check and hence it
is impossible for ret to be less that zero at the point of the
check. Remove this redundant error check.
Detected by CoveritScan, CID#1469407 ("Logically Dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/xen/xen_snd_front_evtchnl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
index d70a62e7f910..102d6e096cc8 100644
--- a/sound/xen/xen_snd_front_evtchnl.c
+++ b/sound/xen/xen_snd_front_evtchnl.c
@@ -351,8 +351,6 @@ int xen_snd_front_evtchnl_create_all(struct xen_snd_front_info *front_info,
}
}
}
- if (ret < 0)
- goto fail;
front_info->num_evt_pairs = num_streams;
return 0;
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] ALSA: xen-front: remove redundant error check on ret
2018-05-27 21:23 [PATCH][next] ALSA: xen-front: remove redundant error check on ret Colin King
@ 2018-05-27 22:42 ` Takashi Sakamoto
2018-05-28 9:29 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Sakamoto @ 2018-05-27 22:42 UTC (permalink / raw)
To: Colin King, Oleksandr Andrushchenko, Jaroslav Kysela,
Takashi Iwai, xen-devel, alsa-devel
Cc: kernel-janitors, linux-kernel
Hi,
On May 28 2018 06:23, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The error for a -ve value in ret is redundant as all previous
> assignments to ret have an associated -ve check and hence it
> is impossible for ret to be less that zero at the point of the
> check. Remove this redundant error check.
>
> Detected by CoveritScan, CID#1469407 ("Logically Dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/xen/xen_snd_front_evtchnl.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
> index d70a62e7f910..102d6e096cc8 100644
> --- a/sound/xen/xen_snd_front_evtchnl.c
> +++ b/sound/xen/xen_snd_front_evtchnl.c
> @@ -351,8 +351,6 @@ int xen_snd_front_evtchnl_create_all(struct xen_snd_front_info *front_info,
> }
> }
> }
> - if (ret < 0)
> - goto fail;
>
> front_info->num_evt_pairs = num_streams;
> return 0;
Yep. All branches for error path on the nested for loop have goto
statement, thus no need to check error outer the loop.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Takashi Sakamoto
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] ALSA: xen-front: remove redundant error check on ret
2018-05-27 22:42 ` Takashi Sakamoto
@ 2018-05-28 9:29 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2018-05-28 9:29 UTC (permalink / raw)
To: Takashi Sakamoto
Cc: alsa-devel, Colin King, Oleksandr Andrushchenko, xen-devel,
Jaroslav Kysela, kernel-janitors, linux-kernel
On Mon, 28 May 2018 00:42:12 +0200,
Takashi Sakamoto wrote:
>
> Hi,
>
> On May 28 2018 06:23, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The error for a -ve value in ret is redundant as all previous
> > assignments to ret have an associated -ve check and hence it
> > is impossible for ret to be less that zero at the point of the
> > check. Remove this redundant error check.
> >
> > Detected by CoveritScan, CID#1469407 ("Logically Dead code")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > sound/xen/xen_snd_front_evtchnl.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
> > index d70a62e7f910..102d6e096cc8 100644
> > --- a/sound/xen/xen_snd_front_evtchnl.c
> > +++ b/sound/xen/xen_snd_front_evtchnl.c
> > @@ -351,8 +351,6 @@ int xen_snd_front_evtchnl_create_all(struct xen_snd_front_info *front_info,
> > }
> > }
> > }
> > - if (ret < 0)
> > - goto fail;
> > front_info->num_evt_pairs = num_streams;
> > return 0;
>
> Yep. All branches for error path on the nested for loop have goto
> statement, thus no need to check error outer the loop.
>
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-28 16:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-27 21:23 [PATCH][next] ALSA: xen-front: remove redundant error check on ret Colin King
2018-05-27 22:42 ` Takashi Sakamoto
2018-05-28 9:29 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®