* [PATCH] ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration
@ 2019-03-17 23:21 Colin King
2019-03-18 12:50 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-03-17 23:21 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, alsa-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function snd_opl3_drum_switch declaration in the header file
has the order of the two arguments on_off and vel swapped when
compared to the definition arguments of vel and on_off. Fix this
by swapping them around to match the definition.
This error predates the git history, so no idea when this error
was introduced.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/drivers/opl3/opl3_voice.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/drivers/opl3/opl3_voice.h b/sound/drivers/opl3/opl3_voice.h
index 5b02bd49fde4..4e4ecc21760b 100644
--- a/sound/drivers/opl3/opl3_voice.h
+++ b/sound/drivers/opl3/opl3_voice.h
@@ -41,7 +41,7 @@ void snd_opl3_timer_func(struct timer_list *t);
/* Prototypes for opl3_drums.c */
void snd_opl3_load_drums(struct snd_opl3 *opl3);
-void snd_opl3_drum_switch(struct snd_opl3 *opl3, int note, int on_off, int vel, struct snd_midi_channel *chan);
+void snd_opl3_drum_switch(struct snd_opl3 *opl3, int note, int vel, int on_off, struct snd_midi_channel *chan);
/* Prototypes for opl3_oss.c */
#if IS_ENABLED(CONFIG_SND_SEQUENCER_OSS)
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration
2019-03-17 23:21 [PATCH] ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration Colin King
@ 2019-03-18 12:50 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-03-18 12:50 UTC (permalink / raw)
To: Colin King; +Cc: alsa-devel, Jaroslav Kysela, kernel-janitors, linux-kernel
On Mon, 18 Mar 2019 00:21:24 +0100,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The function snd_opl3_drum_switch declaration in the header file
> has the order of the two arguments on_off and vel swapped when
> compared to the definition arguments of vel and on_off. Fix this
> by swapping them around to match the definition.
>
> This error predates the git history, so no idea when this error
> was introduced.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-18 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-17 23:21 [PATCH] ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration Colin King
2019-03-18 12:50 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®