* [PATCH] midi: avoid freeing umidi object twice
@ 2016-02-13 8:08 Andrey Konovalov
2016-02-13 8:41 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Konovalov @ 2016-02-13 8:08 UTC (permalink / raw)
To: Clemens Ladisch, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
Cc: dvyukov, kcc, glider, Andrey Konovalov
The 'umidi' object will be free'd on the error path by snd_usbmidi_free()
when tearing down the rawmidi interface. So we shouldn't try to free it
in snd_usbmidi_create() after having registered the rawmidi interface.
Found by KASAN.
Acked-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>
---
sound/usb/midi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/usb/midi.c b/sound/usb/midi.c
index cc39f63..007cf58 100644
--- a/sound/usb/midi.c
+++ b/sound/usb/midi.c
@@ -2455,7 +2455,6 @@ int snd_usbmidi_create(struct snd_card *card,
else
err = snd_usbmidi_create_endpoints(umidi, endpoints);
if (err < 0) {
- snd_usbmidi_free(umidi);
return err;
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] midi: avoid freeing umidi object twice
2016-02-13 8:08 [PATCH] midi: avoid freeing umidi object twice Andrey Konovalov
@ 2016-02-13 8:41 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-02-13 8:41 UTC (permalink / raw)
To: Andrey Konovalov
Cc: alsa-devel, Clemens Ladisch, Jaroslav Kysela, linux-kernel,
dvyukov, glider, kcc
On Sat, 13 Feb 2016 09:08:06 +0100,
Andrey Konovalov wrote:
>
> The 'umidi' object will be free'd on the error path by snd_usbmidi_free()
> when tearing down the rawmidi interface. So we shouldn't try to free it
> in snd_usbmidi_create() after having registered the rawmidi interface.
>
> Found by KASAN.
>
> Acked-by: Clemens Ladisch <clemens@ladisch.de>
> Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>
Thanks, applied now with Cc to stable.
Takashi
> ---
> sound/usb/midi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> index cc39f63..007cf58 100644
> --- a/sound/usb/midi.c
> +++ b/sound/usb/midi.c
> @@ -2455,7 +2455,6 @@ int snd_usbmidi_create(struct snd_card *card,
> else
> err = snd_usbmidi_create_endpoints(umidi, endpoints);
> if (err < 0) {
> - snd_usbmidi_free(umidi);
> return err;
> }
>
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-13 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-13 8:08 [PATCH] midi: avoid freeing umidi object twice Andrey Konovalov
2016-02-13 8:41 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®