mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ctxfi: remove unused variable
Date: Tue, 21 Oct 2014 15:56:59 +0200	[thread overview]
Message-ID: <s5hppdlzftg.wl-tiwai@suse.de> (raw)
In-Reply-To: <1413889127-18754-1-git-send-email-sudipm.mukherjee@gmail.com>

At Tue, 21 Oct 2014 16:28:47 +0530,
Sudip Mukherjee wrote:
> 
> As of now the pointer to struct dai is not being used anywhere in the
> function. So it is safe to remove the variable.
> If we are ever doing anything with the container_of(daio, struct dai, daio),
> then at that time we can again add the variable.   
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Applied, thanks.


Takashi

> ---
>  sound/pci/ctxfi/ctatc.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
> index 4546590..632e843 100644
> --- a/sound/pci/ctxfi/ctatc.c
> +++ b/sound/pci/ctxfi/ctatc.c
> @@ -1145,7 +1145,6 @@ static int atc_release_resources(struct ct_atc *atc)
>  	int i;
>  	struct daio_mgr *daio_mgr = NULL;
>  	struct dao *dao = NULL;
> -	struct dai *dai = NULL;
>  	struct daio *daio = NULL;
>  	struct sum_mgr *sum_mgr = NULL;
>  	struct src_mgr *src_mgr = NULL;
> @@ -1172,9 +1171,6 @@ static int atc_release_resources(struct ct_atc *atc)
>  				dao = container_of(daio, struct dao, daio);
>  				dao->ops->clear_left_input(dao);
>  				dao->ops->clear_right_input(dao);
> -			} else {
> -				dai = container_of(daio, struct dai, daio);
> -				/* some thing to do for dai ... */
>  			}
>  			daio_mgr->put_daio(daio_mgr, daio);
>  		}
> -- 
> 1.8.1.2
> 

      reply	other threads:[~2014-10-21 13:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21 10:58 Sudip Mukherjee
2014-10-21 13:56 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hppdlzftg.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®