* [PATCH] ALSA: ctxfi: remove unused variable
@ 2014-10-21 10:58 Sudip Mukherjee
2014-10-21 13:56 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2014-10-21 10:58 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Sudip Mukherjee, alsa-devel, linux-kernel
As of now the pointer to struct dai is not being used anywhere in the
function. So it is safe to remove the variable.
If we are ever doing anything with the container_of(daio, struct dai, daio),
then at that time we can again add the variable.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
sound/pci/ctxfi/ctatc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
index 4546590..632e843 100644
--- a/sound/pci/ctxfi/ctatc.c
+++ b/sound/pci/ctxfi/ctatc.c
@@ -1145,7 +1145,6 @@ static int atc_release_resources(struct ct_atc *atc)
int i;
struct daio_mgr *daio_mgr = NULL;
struct dao *dao = NULL;
- struct dai *dai = NULL;
struct daio *daio = NULL;
struct sum_mgr *sum_mgr = NULL;
struct src_mgr *src_mgr = NULL;
@@ -1172,9 +1171,6 @@ static int atc_release_resources(struct ct_atc *atc)
dao = container_of(daio, struct dao, daio);
dao->ops->clear_left_input(dao);
dao->ops->clear_right_input(dao);
- } else {
- dai = container_of(daio, struct dai, daio);
- /* some thing to do for dai ... */
}
daio_mgr->put_daio(daio_mgr, daio);
}
--
1.8.1.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: ctxfi: remove unused variable
2014-10-21 10:58 [PATCH] ALSA: ctxfi: remove unused variable Sudip Mukherjee
@ 2014-10-21 13:56 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2014-10-21 13:56 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel
At Tue, 21 Oct 2014 16:28:47 +0530,
Sudip Mukherjee wrote:
>
> As of now the pointer to struct dai is not being used anywhere in the
> function. So it is safe to remove the variable.
> If we are ever doing anything with the container_of(daio, struct dai, daio),
> then at that time we can again add the variable.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Applied, thanks.
Takashi
> ---
> sound/pci/ctxfi/ctatc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
> index 4546590..632e843 100644
> --- a/sound/pci/ctxfi/ctatc.c
> +++ b/sound/pci/ctxfi/ctatc.c
> @@ -1145,7 +1145,6 @@ static int atc_release_resources(struct ct_atc *atc)
> int i;
> struct daio_mgr *daio_mgr = NULL;
> struct dao *dao = NULL;
> - struct dai *dai = NULL;
> struct daio *daio = NULL;
> struct sum_mgr *sum_mgr = NULL;
> struct src_mgr *src_mgr = NULL;
> @@ -1172,9 +1171,6 @@ static int atc_release_resources(struct ct_atc *atc)
> dao = container_of(daio, struct dao, daio);
> dao->ops->clear_left_input(dao);
> dao->ops->clear_right_input(dao);
> - } else {
> - dai = container_of(daio, struct dai, daio);
> - /* some thing to do for dai ... */
> }
> daio_mgr->put_daio(daio_mgr, daio);
> }
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-21 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-21 10:58 [PATCH] ALSA: ctxfi: remove unused variable Sudip Mukherjee
2014-10-21 13:56 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®