mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: oss: mpu401.c:  Cleaning up missing break in a case
Date: Tue, 24 Jun 2014 14:17:28 +0200	[thread overview]
Message-ID: <s5hr42ezelj.wl%tiwai@suse.de> (raw)
In-Reply-To: <1403606975-12827-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

At Tue, 24 Jun 2014 12:49:35 +0200,
Rickard Strandqvist wrote:
> 
> Added a missed break in a case statement
> 
> This was found using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Thanks, applied.


Takashi

> ---
>  sound/oss/mpu401.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
> index 25e4609..400896b 100644
> --- a/sound/oss/mpu401.c
> +++ b/sound/oss/mpu401.c
> @@ -316,6 +316,7 @@ static int mpu_input_scanner(struct mpu_config *devc, unsigned char midic)
>  				case 0xf6:
>  					/* printk( "tune_request\n"); */
>  					devc->m_state = ST_INIT;
> +					break;
>  
>  					/*
>  					 *    Real time messages
> -- 
> 1.7.10.4
> 

      reply	other threads:[~2014-06-24 12:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 10:49 Rickard Strandqvist
2014-06-24 12:17 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr42ezelj.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rickard_strandqvist@spectrumdigital.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®