* [PATCH] sound: oss: mpu401.c: Cleaning up missing break in a case
@ 2014-06-24 10:49 Rickard Strandqvist
2014-06-24 12:17 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-06-24 10:49 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: Rickard Strandqvist, alsa-devel, linux-kernel
Added a missed break in a case statement
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
sound/oss/mpu401.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
index 25e4609..400896b 100644
--- a/sound/oss/mpu401.c
+++ b/sound/oss/mpu401.c
@@ -316,6 +316,7 @@ static int mpu_input_scanner(struct mpu_config *devc, unsigned char midic)
case 0xf6:
/* printk( "tune_request\n"); */
devc->m_state = ST_INIT;
+ break;
/*
* Real time messages
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sound: oss: mpu401.c: Cleaning up missing break in a case
2014-06-24 10:49 [PATCH] sound: oss: mpu401.c: Cleaning up missing break in a case Rickard Strandqvist
@ 2014-06-24 12:17 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2014-06-24 12:17 UTC (permalink / raw)
To: Rickard Strandqvist; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel
At Tue, 24 Jun 2014 12:49:35 +0200,
Rickard Strandqvist wrote:
>
> Added a missed break in a case statement
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Thanks, applied.
Takashi
> ---
> sound/oss/mpu401.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
> index 25e4609..400896b 100644
> --- a/sound/oss/mpu401.c
> +++ b/sound/oss/mpu401.c
> @@ -316,6 +316,7 @@ static int mpu_input_scanner(struct mpu_config *devc, unsigned char midic)
> case 0xf6:
> /* printk( "tune_request\n"); */
> devc->m_state = ST_INIT;
> + break;
>
> /*
> * Real time messages
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-24 12:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-24 10:49 [PATCH] sound: oss: mpu401.c: Cleaning up missing break in a case Rickard Strandqvist
2014-06-24 12:17 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®