mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Jaroslav Kysela <perex@perex.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: Fix make allmodconfig on MIPS correctly
Date: Mon, 13 May 2013 15:55:01 +0200	[thread overview]
Message-ID: <s5hsj1rq91m.wl%tiwai@suse.de> (raw)
In-Reply-To: <1368361879.1350.13.camel@x61.thuisdomein>

At Sun, 12 May 2013 14:31:19 +0200,
Paul Bolle wrote:
> 
> Commit d4702b189c ("sound: Fix make allmodconfig on MIPS") added a
> (negative) dependency on ISA_DMA_SUPPORT_BROKEN. Since that Kconfig
> symbol doesn't exist, this dependency will always evaluate to true.
> Apparently GENERIC_ISA_DMA_SUPPORT_BROKEN was meant to be used here.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Thanks, applied.


Takashi

> ---
> Tested only with "git grep".
> 
>  sound/oss/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/oss/Kconfig b/sound/oss/Kconfig
> index 51c4ba9..1a96402 100644
> --- a/sound/oss/Kconfig
> +++ b/sound/oss/Kconfig
> @@ -250,7 +250,7 @@ config MSND_FIFOSIZE
>  menuconfig SOUND_OSS
>  	tristate "OSS sound modules"
>  	depends on ISA_DMA_API && VIRT_TO_BUS
> -	depends on !ISA_DMA_SUPPORT_BROKEN
> +	depends on !GENERIC_ISA_DMA_SUPPORT_BROKEN
>  	help
>  	  OSS is the Open Sound System suite of sound card drivers.  They make
>  	  sound programming easier since they provide a common API.  Say Y or
> -- 
> 1.7.11.7
> 

      reply	other threads:[~2013-05-13 13:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-12 12:31 Paul Bolle
2013-05-13 13:55 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hsj1rq91m.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=perex@perex.cz \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®