mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] sound: Fix make allmodconfig on MIPS correctly
@ 2013-05-12 12:31 Paul Bolle
  2013-05-13 13:55 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2013-05-12 12:31 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai
  Cc: Andrew Morton, Ralf Baechle, alsa-devel, linux-kernel

Commit d4702b189c ("sound: Fix make allmodconfig on MIPS") added a
(negative) dependency on ISA_DMA_SUPPORT_BROKEN. Since that Kconfig
symbol doesn't exist, this dependency will always evaluate to true.
Apparently GENERIC_ISA_DMA_SUPPORT_BROKEN was meant to be used here.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested only with "git grep".

 sound/oss/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/oss/Kconfig b/sound/oss/Kconfig
index 51c4ba9..1a96402 100644
--- a/sound/oss/Kconfig
+++ b/sound/oss/Kconfig
@@ -250,7 +250,7 @@ config MSND_FIFOSIZE
 menuconfig SOUND_OSS
 	tristate "OSS sound modules"
 	depends on ISA_DMA_API && VIRT_TO_BUS
-	depends on !ISA_DMA_SUPPORT_BROKEN
+	depends on !GENERIC_ISA_DMA_SUPPORT_BROKEN
 	help
 	  OSS is the Open Sound System suite of sound card drivers.  They make
 	  sound programming easier since they provide a common API.  Say Y or
-- 
1.7.11.7


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sound: Fix make allmodconfig on MIPS correctly
  2013-05-12 12:31 [PATCH] sound: Fix make allmodconfig on MIPS correctly Paul Bolle
@ 2013-05-13 13:55 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2013-05-13 13:55 UTC (permalink / raw)
  To: Paul Bolle
  Cc: Jaroslav Kysela, Andrew Morton, Ralf Baechle, alsa-devel, linux-kernel

At Sun, 12 May 2013 14:31:19 +0200,
Paul Bolle wrote:
> 
> Commit d4702b189c ("sound: Fix make allmodconfig on MIPS") added a
> (negative) dependency on ISA_DMA_SUPPORT_BROKEN. Since that Kconfig
> symbol doesn't exist, this dependency will always evaluate to true.
> Apparently GENERIC_ISA_DMA_SUPPORT_BROKEN was meant to be used here.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Thanks, applied.


Takashi

> ---
> Tested only with "git grep".
> 
>  sound/oss/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/oss/Kconfig b/sound/oss/Kconfig
> index 51c4ba9..1a96402 100644
> --- a/sound/oss/Kconfig
> +++ b/sound/oss/Kconfig
> @@ -250,7 +250,7 @@ config MSND_FIFOSIZE
>  menuconfig SOUND_OSS
>  	tristate "OSS sound modules"
>  	depends on ISA_DMA_API && VIRT_TO_BUS
> -	depends on !ISA_DMA_SUPPORT_BROKEN
> +	depends on !GENERIC_ISA_DMA_SUPPORT_BROKEN
>  	help
>  	  OSS is the Open Sound System suite of sound card drivers.  They make
>  	  sound programming easier since they provide a common API.  Say Y or
> -- 
> 1.7.11.7
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-13 13:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-12 12:31 [PATCH] sound: Fix make allmodconfig on MIPS correctly Paul Bolle
2013-05-13 13:55 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®