* [PATCH] Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()
@ 2006-10-03 12:33 Karsten Wiese
2006-10-04 15:25 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Karsten Wiese @ 2006-10-03 12:33 UTC (permalink / raw)
To: linux-kernel, alsa-devel, Takashi Iwai
Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()
substream can be NULL......
in mainline, bug was introduced by:
2006-06-22 [ALSA] Add O_APPEND flag support to PCM
Signed-off-by: Karsten Wiese <annabellesgarden@yahoo.de>
--- alsa-kernel/usb/usx2y/usx2yhwdeppcm.c~ 2006-06-29 23:25:30.000000000 +0200
+++ alsa-kernel/usb/usx2y/usx2yhwdeppcm.c 2006-10-03 14:05:12.000000000 +0200
@@ -632,7 +632,7 @@ static int usX2Y_pcms_lock_check(struct
for (s = 0; s < 2; ++s) {
struct snd_pcm_substream *substream;
substream = pcm->streams[s].substream;
- if (SUBSTREAM_BUSY(substream))
+ if (substream && SUBSTREAM_BUSY(substream))
err = -EBUSY;
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()
2006-10-03 12:33 [PATCH] Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check() Karsten Wiese
@ 2006-10-04 15:25 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2006-10-04 15:25 UTC (permalink / raw)
To: Karsten Wiese; +Cc: linux-kernel, alsa-devel
At Tue, 3 Oct 2006 14:33:56 +0200,
Karsten Wiese wrote:
>
> Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()
>
> substream can be NULL......
> in mainline, bug was introduced by:
> 2006-06-22 [ALSA] Add O_APPEND flag support to PCM
>
> Signed-off-by: Karsten Wiese <annabellesgarden@yahoo.de>
Thanks, merged to ALSA tree.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-04 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-03 12:33 [PATCH] Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check() Karsten Wiese
2006-10-04 15:25 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®