* [PATCH] hda: realtek: Make dock sound work on ThinkPad L570
@ 2018-03-08 12:17 Dennis Wassenberg
2018-03-08 12:57 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Dennis Wassenberg @ 2018-03-08 12:17 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Hui Wang; +Cc: alsa-devel, linux-kernel
One version of Lenovo Thinkpad T570 did not use ALC298
(like other Kaby Lake devices). Instead it uses ALC292.
In order to make the Lenovo dock working with that codec
the dock quirk for ALC292 will be used.
Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b9c93fa..b5d0f8c 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6508,6 +6508,7 @@ enum {
SND_PCI_QUIRK(0x17aa, 0x2245, "Thinkpad T470", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x2246, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x2247, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
+ SND_PCI_QUIRK(0x17aa, 0x2249, "Thinkpad", ALC292_FIXUP_TPT460),
SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hda: realtek: Make dock sound work on ThinkPad L570
2018-03-08 12:17 [PATCH] hda: realtek: Make dock sound work on ThinkPad L570 Dennis Wassenberg
@ 2018-03-08 12:57 ` Takashi Iwai
2018-03-08 13:13 ` Dennis Wassenberg
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2018-03-08 12:57 UTC (permalink / raw)
To: Dennis Wassenberg; +Cc: Hui Wang, Jaroslav Kysela, alsa-devel, linux-kernel
On Thu, 08 Mar 2018 13:17:54 +0100,
Dennis Wassenberg wrote:
>
> One version of Lenovo Thinkpad T570 did not use ALC298
> (like other Kaby Lake devices). Instead it uses ALC292.
> In order to make the Lenovo dock working with that codec
> the dock quirk for ALC292 will be used.
>
> Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
So, although the PCI SSID appears to be a new one, this still needs
the old quirk, not for T470 dock? Just to be sure.
thanks,
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b9c93fa..b5d0f8c 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6508,6 +6508,7 @@ enum {
> SND_PCI_QUIRK(0x17aa, 0x2245, "Thinkpad T470", ALC298_FIXUP_TPT470_DOCK),
> SND_PCI_QUIRK(0x17aa, 0x2246, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> SND_PCI_QUIRK(0x17aa, 0x2247, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> + SND_PCI_QUIRK(0x17aa, 0x2249, "Thinkpad", ALC292_FIXUP_TPT460),
> SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> --
> 1.9.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hda: realtek: Make dock sound work on ThinkPad L570
2018-03-08 12:57 ` Takashi Iwai
@ 2018-03-08 13:13 ` Dennis Wassenberg
2018-03-08 13:34 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Dennis Wassenberg @ 2018-03-08 13:13 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Hui Wang, Jaroslav Kysela, alsa-devel, linux-kernel
Hi Takashi,
yes, exactly.
First I was confused because all other Lenovo 70's devices have ALC298
inside, even L470, but not L570 with this PCI SSID.
Best regards,
Dennis
On 08.03.2018 13:57, Takashi Iwai wrote:
> On Thu, 08 Mar 2018 13:17:54 +0100,
> Dennis Wassenberg wrote:
>>
>> One version of Lenovo Thinkpad T570 did not use ALC298
>> (like other Kaby Lake devices). Instead it uses ALC292.
>> In order to make the Lenovo dock working with that codec
>> the dock quirk for ALC292 will be used.
>>
>> Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
>
> So, although the PCI SSID appears to be a new one, this still needs
> the old quirk, not for T470 dock? Just to be sure.
>
>
> thanks,
>
> Takashi
>
>> ---
>> sound/pci/hda/patch_realtek.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index b9c93fa..b5d0f8c 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -6508,6 +6508,7 @@ enum {
>> SND_PCI_QUIRK(0x17aa, 0x2245, "Thinkpad T470", ALC298_FIXUP_TPT470_DOCK),
>> SND_PCI_QUIRK(0x17aa, 0x2246, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>> SND_PCI_QUIRK(0x17aa, 0x2247, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>> + SND_PCI_QUIRK(0x17aa, 0x2249, "Thinkpad", ALC292_FIXUP_TPT460),
>> SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>> SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>> SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>> --
>> 1.9.1
>>
>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hda: realtek: Make dock sound work on ThinkPad L570
2018-03-08 13:13 ` Dennis Wassenberg
@ 2018-03-08 13:34 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2018-03-08 13:34 UTC (permalink / raw)
To: Dennis Wassenberg; +Cc: Hui Wang, Jaroslav Kysela, alsa-devel, linux-kernel
On Thu, 08 Mar 2018 14:13:20 +0100,
Dennis Wassenberg wrote:
>
> Hi Takashi,
>
> yes, exactly.
>
> First I was confused because all other Lenovo 70's devices have ALC298
> inside, even L470, but not L570 with this PCI SSID.
All right, I merged it now. Thanks!
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-08 13:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08 12:17 [PATCH] hda: realtek: Make dock sound work on ThinkPad L570 Dennis Wassenberg
2018-03-08 12:57 ` Takashi Iwai
2018-03-08 13:13 ` Dennis Wassenberg
2018-03-08 13:34 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®