* [PATCH 4/4] sound/pci: Drop unnecessary continue
@ 2007-11-14 8:15 Julia Lawall
2007-11-14 10:01 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2007-11-14 8:15 UTC (permalink / raw)
To: perex, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Continue is not needed at the bottom of a loop.
The semantic patch implementing this change is as follows:
@@
@@
for (...;...;...) {
...
if (...) {
...
- continue;
}
}
Signed-off-by: Julia Lawall <julia@diku.dk>
---
diff -u -p -b -B a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
--- a/sound/pci/intel8x0.c 2007-10-22 11:25:53.000000000 +0200
+++ b/sound/pci/intel8x0.c 2007-11-13 23:53:44.000000000 +0100
@@ -2144,7 +2144,6 @@ static int __devinit snd_intel8x0_mixer(
snd_printk(KERN_ERR "Unable to initialize codec #%d\n", i);
if (i == 0)
goto __err;
- continue;
}
}
/* tune up the primary codec */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] sound/pci: Drop unnecessary continue
2007-11-14 8:15 [PATCH 4/4] sound/pci: Drop unnecessary continue Julia Lawall
@ 2007-11-14 10:01 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2007-11-14 10:01 UTC (permalink / raw)
To: Julia Lawall; +Cc: perex, linux-kernel, kernel-janitors
At Wed, 14 Nov 2007 09:15:51 +0100 (CET),
Julia Lawall wrote:
>
> From: Julia Lawall <julia@diku.dk>
>
> Continue is not needed at the bottom of a loop.
>
> The semantic patch implementing this change is as follows:
>
> @@
> @@
>
> for (...;...;...) {
> ...
> if (...) {
> ...
> - continue;
> }
> }
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied to ALSA tree. Thanks.
Takashi
> ---
>
> diff -u -p -b -B a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
> --- a/sound/pci/intel8x0.c 2007-10-22 11:25:53.000000000 +0200
> +++ b/sound/pci/intel8x0.c 2007-11-13 23:53:44.000000000 +0100
> @@ -2144,7 +2144,6 @@ static int __devinit snd_intel8x0_mixer(
> snd_printk(KERN_ERR "Unable to initialize codec #%d\n", i);
> if (i == 0)
> goto __err;
> - continue;
> }
> }
> /* tune up the primary codec */
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-14 13:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-14 8:15 [PATCH 4/4] sound/pci: Drop unnecessary continue Julia Lawall
2007-11-14 10:01 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®