From: Takashi Iwai <tiwai@suse.de>
To: "Jia-Ju Bai" <baijiaju1990@gmail.com>
Cc: <kai.heng.feng@canonical.com>, <nob77413@gmail.com>,
<ruslan.bilovol@gmail.com>, <perex@perex.cz>,
<jussi@sonarnerd.net>, <elfring@users.sourceforge.net>,
<daniel@zonque.org>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: usb: quirks: Replace mdelay() with msleep() and usleep_range()
Date: Fri, 27 Jul 2018 11:48:28 +0200 [thread overview]
Message-ID: <s5hzhydxb4j.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180727085528.5802-1-baijiaju1990@gmail.com>
On Fri, 27 Jul 2018 10:55:28 +0200,
Jia-Ju Bai wrote:
>
> snd_usb_select_mode_quirk(), snd_usb_set_interface_quirk() and
> snd_usb_ctl_msg_quirk() are never called in atomic context.
> They call mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep() and usleep_range().
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2018-07-27 9:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 8:55 Jia-Ju Bai
2018-07-27 9:48 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzhydxb4j.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=baijiaju1990@gmail.com \
--cc=daniel@zonque.org \
--cc=elfring@users.sourceforge.net \
--cc=jussi@sonarnerd.net \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nob77413@gmail.com \
--cc=perex@perex.cz \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®