[PATCH] trace: export trace_profile_buf symbols

[PATCH] trace: export trace_profile_buf symbols

[Peter Zijlstra]

ERROR: "trace_profile_buf_nmi" [fs/jbd2/jbd2.ko] undefined!                                                                        
ERROR: "trace_profile_buf" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf_nmi" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf_nmi" [arch/x86/kvm/kvm.ko] undefined!
ERROR: "trace_profile_buf" [arch/x86/kvm/kvm.ko] undefined!

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 kernel/trace/trace_event_profile.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/trace_event_profile.c b/kernel/trace/trace_event_profile.c
index 3aaa77c..f65e966 100644
--- a/kernel/trace/trace_event_profile.c
+++ b/kernel/trace/trace_event_profile.c
@@ -17,6 +17,9 @@ typedef struct {char buf[FTRACE_MAX_PROFILE_SIZE];} profile_buf_t;
 char		*trace_profile_buf;
 char 		*trace_profile_buf_nmi;
 
+EXPORT_SYMBOL_GPL(trace_profile_buf);
+EXPORT_SYMBOL_GPL(trace_profile_buf_nmi);
+
 /* Count the events in use (per event id, not per instance) */
 static int	total_profile_count;
 

Re: [PATCH] trace: export trace_profile_buf symbols

[Steven Rostedt]

On Sun, 2009-09-20 at 12:34 +0200, Peter Zijlstra wrote:
> ERROR: "trace_profile_buf_nmi" [fs/jbd2/jbd2.ko] undefined!                                                                        
> ERROR: "trace_profile_buf" [fs/jbd2/jbd2.ko] undefined!
> ERROR: "trace_profile_buf_nmi" [fs/ext4/ext4.ko] undefined!
> ERROR: "trace_profile_buf" [fs/ext4/ext4.ko] undefined!
> ERROR: "trace_profile_buf_nmi" [arch/x86/kvm/kvm.ko] undefined!
> ERROR: "trace_profile_buf" [arch/x86/kvm/kvm.ko] undefined!
> 

Peter, I thought you never use modules.

> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> ---
>  kernel/trace/trace_event_profile.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/trace/trace_event_profile.c b/kernel/trace/trace_event_profile.c
> index 3aaa77c..f65e966 100644
> --- a/kernel/trace/trace_event_profile.c
> +++ b/kernel/trace/trace_event_profile.c
> @@ -17,6 +17,9 @@ typedef struct {char buf[FTRACE_MAX_PROFILE_SIZE];} profile_buf_t;
>  char		*trace_profile_buf;
>  char 		*trace_profile_buf_nmi;
>  
> +EXPORT_SYMBOL_GPL(trace_profile_buf);
> +EXPORT_SYMBOL_GPL(trace_profile_buf_nmi);
> +
>  /* Count the events in use (per event id, not per instance) */
>  static int	total_profile_count;
>  
> 
> 

Re: [PATCH] trace: export trace_profile_buf symbols

[Frédéric Weisbecker]

Le 20 septembre 2009 13:23, Steven Rostedt <rostedt@goodmis.org> a écrit :
> On Sun, 2009-09-20 at 12:34 +0200, Peter Zijlstra wrote:
>> ERROR: "trace_profile_buf_nmi" [fs/jbd2/jbd2.ko] undefined!
>> ERROR: "trace_profile_buf" [fs/jbd2/jbd2.ko] undefined!
>> ERROR: "trace_profile_buf_nmi" [fs/ext4/ext4.ko] undefined!
>> ERROR: "trace_profile_buf" [fs/ext4/ext4.ko] undefined!
>> ERROR: "trace_profile_buf_nmi" [arch/x86/kvm/kvm.ko] undefined!
>> ERROR: "trace_profile_buf" [arch/x86/kvm/kvm.ko] undefined!
>>
>
> Peter, I thought you never use modules.


And I forgot to think about them :-/


>> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>



>
> -- Steve
>
>> ---
>>  kernel/trace/trace_event_profile.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/kernel/trace/trace_event_profile.c b/kernel/trace/trace_event_profile.c
>> index 3aaa77c..f65e966 100644
>> --- a/kernel/trace/trace_event_profile.c
>> +++ b/kernel/trace/trace_event_profile.c
>> @@ -17,6 +17,9 @@ typedef struct {char buf[FTRACE_MAX_PROFILE_SIZE];} profile_buf_t;
>>  char         *trace_profile_buf;
>>  char                 *trace_profile_buf_nmi;
>>
>> +EXPORT_SYMBOL_GPL(trace_profile_buf);
>> +EXPORT_SYMBOL_GPL(trace_profile_buf_nmi);
>> +
>>  /* Count the events in use (per event id, not per instance) */
>>  static int   total_profile_count;
>>
>>
>>
>
>

[tip:tracing/urgent] tracing: Export trace_profile_buf symbols

[tip-bot for Peter Zijlstra]

Commit-ID:  05bafda856092de0705de239c846777bddb94974
Gitweb:     http://git.kernel.org/tip/05bafda856092de0705de239c846777bddb94974
Author:     Peter Zijlstra <peterz@infradead.org>
AuthorDate: Sun, 20 Sep 2009 12:34:38 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 20 Sep 2009 19:15:57 +0200

tracing: Export trace_profile_buf symbols

ERROR: "trace_profile_buf_nmi" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf_nmi" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf_nmi" [arch/x86/kvm/kvm.ko] undefined!
ERROR: "trace_profile_buf" [arch/x86/kvm/kvm.ko] undefined!

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1253442878.7542.3.camel@laptop>
[ fixed whitespace noise and checkpatch complaint ]
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 kernel/trace/trace_event_profile.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace_event_profile.c b/kernel/trace/trace_event_profile.c
index 3aaa77c..dd44b87 100644
--- a/kernel/trace/trace_event_profile.c
+++ b/kernel/trace/trace_event_profile.c
@@ -15,7 +15,10 @@
 typedef struct {char buf[FTRACE_MAX_PROFILE_SIZE];} profile_buf_t;
 
 char		*trace_profile_buf;
-char 		*trace_profile_buf_nmi;
+EXPORT_SYMBOL_GPL(trace_profile_buf);
+
+char		*trace_profile_buf_nmi;
+EXPORT_SYMBOL_GPL(trace_profile_buf_nmi);
 
 /* Count the events in use (per event id, not per instance) */
 static int	total_profile_count;