* [PATCH] avr32: Fix build error caused by include file reshuffling
@ 2017-03-06 1:05 Guenter Roeck
2017-03-06 7:12 ` Hans-Christian Noren Egtvedt
2017-03-07 9:04 ` [tip:core/urgent] " tip-bot for Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2017-03-06 1:05 UTC (permalink / raw)
To: Haavard Skinnemoen
Cc: Robert Richter, Hans-Christian Egtvedt, oprofile-list,
linux-kernel, Guenter Roeck, Ingo Molnar
Various avr32 builds fail as follows.
arch/avr32/oprofile/backtrace.c:58: error:
dereferencing pointer to incomplete type
arch/avr32/oprofile/backtrace.c:60: error:
implicit declaration of function 'user_mode'
Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Please feel free to ignore if av32 is going to be removed.
arch/avr32/oprofile/backtrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c
index 75d9ad6f99cf..29cf2f191bfd 100644
--- a/arch/avr32/oprofile/backtrace.c
+++ b/arch/avr32/oprofile/backtrace.c
@@ -14,7 +14,7 @@
*/
#include <linux/oprofile.h>
-#include <linux/sched.h>
+#include <linux/ptrace.h>
#include <linux/uaccess.h>
/* The first two words of each frame on the stack look like this if we have
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] avr32: Fix build error caused by include file reshuffling
2017-03-06 1:05 [PATCH] avr32: Fix build error caused by include file reshuffling Guenter Roeck
@ 2017-03-06 7:12 ` Hans-Christian Noren Egtvedt
2017-03-07 9:04 ` [tip:core/urgent] " tip-bot for Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Hans-Christian Noren Egtvedt @ 2017-03-06 7:12 UTC (permalink / raw)
To: Guenter Roeck
Cc: Haavard Skinnemoen, Robert Richter, oprofile-list, linux-kernel,
Ingo Molnar
Around Sun 05 Mar 2017 17:05:57 -0800 or thereabout, Guenter Roeck wrote:
> Various avr32 builds fail as follows.
>
> arch/avr32/oprofile/backtrace.c:58: error:
> dereferencing pointer to incomplete type
> arch/avr32/oprofile/backtrace.c:60: error:
> implicit declaration of function 'user_mode'
>
> Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>
> ---
> Please feel free to ignore if av32 is going to be removed.
AVR32 is not going away for 4.11, we started the FYI and review process too
late to make the window.
I think I will push it, to make sure AVR32 leaves the kernel in as good state
as possible.
> arch/avr32/oprofile/backtrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c
> index 75d9ad6f99cf..29cf2f191bfd 100644
> --- a/arch/avr32/oprofile/backtrace.c
> +++ b/arch/avr32/oprofile/backtrace.c
> @@ -14,7 +14,7 @@
> */
>
> #include <linux/oprofile.h>
> -#include <linux/sched.h>
> +#include <linux/ptrace.h>
> #include <linux/uaccess.h>
>
> /* The first two words of each frame on the stack look like this if we have
--
mvh
Hans-Christian Noren Egtvedt
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:core/urgent] avr32: Fix build error caused by include file reshuffling
2017-03-06 1:05 [PATCH] avr32: Fix build error caused by include file reshuffling Guenter Roeck
2017-03-06 7:12 ` Hans-Christian Noren Egtvedt
@ 2017-03-07 9:04 ` tip-bot for Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Guenter Roeck @ 2017-03-07 9:04 UTC (permalink / raw)
To: linux-tip-commits
Cc: hpa, linux, hskinnemoen, torvalds, egtvedt, rric, linux-kernel,
tglx, mingo, peterz
Commit-ID: 1fbdbcea80056acfc8c8506594744f5ec52208c1
Gitweb: http://git.kernel.org/tip/1fbdbcea80056acfc8c8506594744f5ec52208c1
Author: Guenter Roeck <linux@roeck-us.net>
AuthorDate: Sun, 5 Mar 2017 17:05:57 -0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 7 Mar 2017 08:35:48 +0100
avr32: Fix build error caused by include file reshuffling
Various avr32 builds fail:
arch/avr32/oprofile/backtrace.c:58: error: dereferencing pointer to incomplete type
arch/avr32/oprofile/backtrace.c:60: error: implicit declaration of function 'user_mode'
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>
Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <rric@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: oprofile-list@lists.sf.net
Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
Link: http://lkml.kernel.org/r/1488762357-4500-1-git-send-email-linux@roeck-us.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/avr32/oprofile/backtrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c
index 75d9ad6..29cf2f1 100644
--- a/arch/avr32/oprofile/backtrace.c
+++ b/arch/avr32/oprofile/backtrace.c
@@ -14,7 +14,7 @@
*/
#include <linux/oprofile.h>
-#include <linux/sched.h>
+#include <linux/ptrace.h>
#include <linux/uaccess.h>
/* The first two words of each frame on the stack look like this if we have
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-07 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-06 1:05 [PATCH] avr32: Fix build error caused by include file reshuffling Guenter Roeck
2017-03-06 7:12 ` Hans-Christian Noren Egtvedt
2017-03-07 9:04 ` [tip:core/urgent] " tip-bot for Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome