mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [tip:timers/urgent] timers, sched: Correct the comments for tick_sched_timer()
  2012-10-24 17:07 sched: correct the comments for tick_sched_timer() Chuansheng Liu
@ 2012-10-24  9:41 ` tip-bot for Chuansheng Liu
  2012-11-01 21:38 ` [tip:timers/core] tick: Correct the comments for tick_sched_timer( ) tip-bot for Chuansheng Liu
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Chuansheng Liu @ 2012-10-24  9:41 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, peterz, tglx, chuansheng.liu

Commit-ID:  351f181f9134d71efd46ddf0c0abca31b58cd79b
Gitweb:     http://git.kernel.org/tip/351f181f9134d71efd46ddf0c0abca31b58cd79b
Author:     Chuansheng Liu <chuansheng.liu@intel.com>
AuthorDate: Thu, 25 Oct 2012 01:07:35 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 24 Oct 2012 10:16:51 +0200

timers, sched: Correct the comments for tick_sched_timer()

In the comments of function tick_sched_timer(), the sentence
"timer->base->cpu_base->lock held" is not right.

In function __run_hrtimer(), before call timer->function(),
the cpu_base->lock has been unlocked.

Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
Cc: fei.li@intel.com
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1351098455.15558.1421.camel@cliu38-desktop-build
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/time/tick-sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index a402608..2bc73d3 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -794,7 +794,7 @@ void tick_check_idle(int cpu)
 #ifdef CONFIG_HIGH_RES_TIMERS
 /*
  * We rearm the timer until we get disabled by the idle code.
- * Called with interrupts disabled and timer->base->cpu_base->lock held.
+ * Called with interrupts disabled.
  */
 static enum hrtimer_restart tick_sched_timer(struct hrtimer *timer)
 {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* sched: correct the comments for tick_sched_timer()
@ 2012-10-24 17:07 Chuansheng Liu
  2012-10-24  9:41 ` [tip:timers/urgent] timers, sched: Correct " tip-bot for Chuansheng Liu
  2012-11-01 21:38 ` [tip:timers/core] tick: Correct the comments for tick_sched_timer( ) tip-bot for Chuansheng Liu
  0 siblings, 2 replies; 3+ messages in thread
From: Chuansheng Liu @ 2012-10-24 17:07 UTC (permalink / raw)
  To: Peter Zijlstra, mingo, tglx; +Cc: linux-kernel, chuansheng.liu, fei.li


In the comments of function tick_sched_timer(), the sentence
"timer->base->cpu_base->lock held" is not right.

In function __run_hrtimer(), before call timer->function(),
the cpu_base->lock has been unlocked.

Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
---
 kernel/time/tick-sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index a402608..2bc73d3 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -794,7 +794,7 @@ void tick_check_idle(int cpu)
 #ifdef CONFIG_HIGH_RES_TIMERS
 /*
  * We rearm the timer until we get disabled by the idle code.
- * Called with interrupts disabled and timer->base->cpu_base->lock held.
+ * Called with interrupts disabled.
  */
 static enum hrtimer_restart tick_sched_timer(struct hrtimer *timer)
 {
-- 
1.7.0.4




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:timers/core] tick: Correct the comments for tick_sched_timer( )
  2012-10-24 17:07 sched: correct the comments for tick_sched_timer() Chuansheng Liu
  2012-10-24  9:41 ` [tip:timers/urgent] timers, sched: Correct " tip-bot for Chuansheng Liu
@ 2012-11-01 21:38 ` tip-bot for Chuansheng Liu
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Chuansheng Liu @ 2012-11-01 21:38 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, peterz, tglx, chuansheng.liu

Commit-ID:  b8f61116c1ce342804a0897b0a80eb4df5f19453
Gitweb:     http://git.kernel.org/tip/b8f61116c1ce342804a0897b0a80eb4df5f19453
Author:     Chuansheng Liu <chuansheng.liu@intel.com>
AuthorDate: Thu, 25 Oct 2012 01:07:35 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 1 Nov 2012 12:13:59 +0100

tick: Correct the comments for tick_sched_timer()

In the comments of function tick_sched_timer(), the sentence
"timer->base->cpu_base->lock held" is not right.

In function __run_hrtimer(), before call timer->function(),
the cpu_base->lock has been unlocked.

Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
Cc: fei.li@intel.com
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1351098455.15558.1421.camel@cliu38-desktop-build
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/time/tick-sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 766d4c4..77729cc 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -809,7 +809,7 @@ void tick_check_idle(int cpu)
 #ifdef CONFIG_HIGH_RES_TIMERS
 /*
  * We rearm the timer until we get disabled by the idle code.
- * Called with interrupts disabled and timer->base->cpu_base->lock held.
+ * Called with interrupts disabled.
  */
 static enum hrtimer_restart tick_sched_timer(struct hrtimer *timer)
 {

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-11-01 21:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-24 17:07 sched: correct the comments for tick_sched_timer() Chuansheng Liu
2012-10-24  9:41 ` [tip:timers/urgent] timers, sched: Correct " tip-bot for Chuansheng Liu
2012-11-01 21:38 ` [tip:timers/core] tick: Correct the comments for tick_sched_timer( ) tip-bot for Chuansheng Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome