* [PATCH] tools: perf: util: fix include for non x86 architectures [not found] <cover.1390829373.git.ffusco@redhat.com> @ 2014-01-27 13:39 ` Francesco Fusco 2014-02-02 8:54 ` [tip:perf/urgent] perf tools: Fix " tip-bot for Francesco Fusco 0 siblings, 1 reply; 2+ messages in thread From: Francesco Fusco @ 2014-01-27 13:39 UTC (permalink / raw) To: acme; +Cc: linux-kernel Commit 71ae8aac ("lib: introduce arch optimized hash library") added an include to <linux/hash.h> for setting up an architecture specific fast hash. Since perf includes directly the non-uapi kernel header, it cannot find <asm/hash.h> on non-x86 and thus prevents perf to be compiled on every architecture other than x86. The problem is the inclusion of <asm/hash.h> in hash.h that results in the following error originating from util/evlist.c: fatal error: asm/hash.h: No such file or directory This commit simply adds an empty <asm/hash.h> stub/file to fix the compile issue on non-x86 architectures. As perf does not use any of these new functions, it fixes the compilation and therefore seems to be the most appropriate solution to go with. Signed-off-by: Francesco Fusco <ffusco@redhat.com> --- tools/perf/util/include/asm/hash.h | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 tools/perf/util/include/asm/hash.h diff --git a/tools/perf/util/include/asm/hash.h b/tools/perf/util/include/asm/hash.h new file mode 100644 index 0000000..d82b170b --- /dev/null +++ b/tools/perf/util/include/asm/hash.h @@ -0,0 +1,6 @@ +#ifndef __ASM_GENERIC_HASH_H +#define __ASM_GENERIC_HASH_H + +/* Stub */ + +#endif /* __ASM_GENERIC_HASH_H */ -- 1.8.3.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:perf/urgent] perf tools: Fix include for non x86 architectures 2014-01-27 13:39 ` [PATCH] tools: perf: util: fix include for non x86 architectures Francesco Fusco @ 2014-02-02 8:54 ` tip-bot for Francesco Fusco 0 siblings, 0 replies; 2+ messages in thread From: tip-bot for Francesco Fusco @ 2014-02-02 8:54 UTC (permalink / raw) To: linux-tip-commits; +Cc: acme, linux-kernel, ffusco, hpa, mingo, tglx Commit-ID: 6a02652df511029127406cf8fa89cdf5e987f963 Gitweb: http://git.kernel.org/tip/6a02652df511029127406cf8fa89cdf5e987f963 Author: Francesco Fusco <ffusco@redhat.com> AuthorDate: Mon, 27 Jan 2014 14:39:13 +0100 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Fri, 31 Jan 2014 17:21:42 -0300 perf tools: Fix include for non x86 architectures Commit 71ae8aac ("lib: introduce arch optimized hash library") added an include to <linux/hash.h> for setting up an architecture specific fast hash. Since perf includes directly the non-uapi kernel header, it cannot find <asm/hash.h> on non-x86 and thus prevents perf to be compiled on every architecture other than x86. The problem is the inclusion of <asm/hash.h> in hash.h that results in the following error originating from util/evlist.c: fatal error: asm/hash.h: No such file or directory This commit simply adds an empty <asm/hash.h> stub/file to fix the compile issue on non-x86 architectures. As perf does not use any of these new functions, it fixes the compilation and therefore seems to be the most appropriate solution to go with. Signed-off-by: Francesco Fusco <ffusco@redhat.com> Link: http://lkml.kernel.org/r/2cf8143aad65a6aa6fe30325ef8a65847141afa2.1390829373.git.ffusco@redhat.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/include/asm/hash.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/perf/util/include/asm/hash.h b/tools/perf/util/include/asm/hash.h new file mode 100644 index 0000000..d82b170b --- /dev/null +++ b/tools/perf/util/include/asm/hash.h @@ -0,0 +1,6 @@ +#ifndef __ASM_GENERIC_HASH_H +#define __ASM_GENERIC_HASH_H + +/* Stub */ + +#endif /* __ASM_GENERIC_HASH_H */ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-02 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1390829373.git.ffusco@redhat.com>
2014-01-27 13:39 ` [PATCH] tools: perf: util: fix include for non x86 architectures Francesco Fusco
2014-02-02 8:54 ` [tip:perf/urgent] perf tools: Fix " tip-bot for Francesco Fusco
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome