* [PATCH 1/2] lockdep: Remove __debug_show_held_locks
@ 2010-08-05 15:10 John Kacur
2010-08-05 15:10 ` [PATCH 2/2] [TRIVIAL] fix grammar by adding a missing "to" in the comments John Kacur
2010-08-17 7:55 ` [tip:core/urgent] lockdep: Remove __debug_show_held_locks tip-bot for John Kacur
0 siblings, 2 replies; 4+ messages in thread
From: John Kacur @ 2010-08-05 15:10 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar; +Cc: lkml, John Kacur
There is no longer any functional difference between
__debug_show_held_locks() and debug_show_held_locks(),
so remove the former.
Signed-off-by: John Kacur <jkacur@redhat.com>
---
include/linux/debug_locks.h | 5 -----
kernel/hung_task.c | 2 +-
kernel/lockdep.c | 8 +-------
3 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
index 29b3ce3..2833452 100644
--- a/include/linux/debug_locks.h
+++ b/include/linux/debug_locks.h
@@ -49,7 +49,6 @@ struct task_struct;
#ifdef CONFIG_LOCKDEP
extern void debug_show_all_locks(void);
-extern void __debug_show_held_locks(struct task_struct *task);
extern void debug_show_held_locks(struct task_struct *task);
extern void debug_check_no_locks_freed(const void *from, unsigned long len);
extern void debug_check_no_locks_held(struct task_struct *task);
@@ -58,10 +57,6 @@ static inline void debug_show_all_locks(void)
{
}
-static inline void __debug_show_held_locks(struct task_struct *task)
-{
-}
-
static inline void debug_show_held_locks(struct task_struct *task)
{
}
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index 0c642d5..bca9423 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -98,7 +98,7 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
printk(KERN_ERR "\"echo 0 > /proc/sys/kernel/hung_task_timeout_secs\""
" disables this message.\n");
sched_show_task(t);
- __debug_show_held_locks(t);
+ debug_show_held_locks(t);
touch_nmi_watchdog();
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 5428679..843030b 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -3775,7 +3775,7 @@ EXPORT_SYMBOL_GPL(debug_show_all_locks);
* Careful: only use this function if you are sure that
* the task cannot run in parallel!
*/
-void __debug_show_held_locks(struct task_struct *task)
+void debug_show_held_locks(struct task_struct *task)
{
if (unlikely(!debug_locks)) {
printk("INFO: lockdep is turned off.\n");
@@ -3783,12 +3783,6 @@ void __debug_show_held_locks(struct task_struct *task)
}
lockdep_print_held_locks(task);
}
-EXPORT_SYMBOL_GPL(__debug_show_held_locks);
-
-void debug_show_held_locks(struct task_struct *task)
-{
- __debug_show_held_locks(task);
-}
EXPORT_SYMBOL_GPL(debug_show_held_locks);
void lockdep_sys_exit(void)
--
1.7.2
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 2/2] [TRIVIAL] fix grammar by adding a missing "to" in the comments
2010-08-05 15:10 [PATCH 1/2] lockdep: Remove __debug_show_held_locks John Kacur
@ 2010-08-05 15:10 ` John Kacur
2010-08-17 7:55 ` [tip:core/urgent] lockup detector: Fix " tip-bot for John Kacur
2010-08-17 7:55 ` [tip:core/urgent] lockdep: Remove __debug_show_held_locks tip-bot for John Kacur
1 sibling, 1 reply; 4+ messages in thread
From: John Kacur @ 2010-08-05 15:10 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar; +Cc: lkml, John Kacur
This fixes a minor grammar problem in the comments in hung_task.c
Signed-off-by: John Kacur <jkacur@redhat.com>
---
kernel/hung_task.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index bca9423..53ead17 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -111,7 +111,7 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
* periodically exit the critical section and enter a new one.
*
* For preemptible RCU it is sufficient to call rcu_read_unlock in order
- * exit the grace period. For classic RCU, a reschedule is required.
+ * to exit the grace period. For classic RCU, a reschedule is required.
*/
static void rcu_lock_break(struct task_struct *g, struct task_struct *t)
{
--
1.7.2
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip:core/urgent] lockup detector: Fix grammar by adding a missing "to" in the comments
2010-08-05 15:10 ` [PATCH 2/2] [TRIVIAL] fix grammar by adding a missing "to" in the comments John Kacur
@ 2010-08-17 7:55 ` tip-bot for John Kacur
0 siblings, 0 replies; 4+ messages in thread
From: tip-bot for John Kacur @ 2010-08-17 7:55 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, jkacur, a.p.zijlstra, tglx, mingo
Commit-ID: 6a103b0d44e9f97dc430002cf3ac7a7defa3819f
Gitweb: http://git.kernel.org/tip/6a103b0d44e9f97dc430002cf3ac7a7defa3819f
Author: John Kacur <jkacur@redhat.com>
AuthorDate: Thu, 5 Aug 2010 17:10:54 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 17 Aug 2010 09:11:52 +0200
lockup detector: Fix grammar by adding a missing "to" in the comments
This fixes a minor grammar problem in the comments in
hung_task.c
Signed-off-by: John Kacur <jkacur@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1281021054-4228-2-git-send-email-jkacur@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/hung_task.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index bca9423..53ead17 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -111,7 +111,7 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
* periodically exit the critical section and enter a new one.
*
* For preemptible RCU it is sufficient to call rcu_read_unlock in order
- * exit the grace period. For classic RCU, a reschedule is required.
+ * to exit the grace period. For classic RCU, a reschedule is required.
*/
static void rcu_lock_break(struct task_struct *g, struct task_struct *t)
{
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:core/urgent] lockdep: Remove __debug_show_held_locks
2010-08-05 15:10 [PATCH 1/2] lockdep: Remove __debug_show_held_locks John Kacur
2010-08-05 15:10 ` [PATCH 2/2] [TRIVIAL] fix grammar by adding a missing "to" in the comments John Kacur
@ 2010-08-17 7:55 ` tip-bot for John Kacur
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for John Kacur @ 2010-08-17 7:55 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, jkacur, a.p.zijlstra, tglx, mingo
Commit-ID: f1b499f029c5dde85d46a8811353c62f29157541
Gitweb: http://git.kernel.org/tip/f1b499f029c5dde85d46a8811353c62f29157541
Author: John Kacur <jkacur@redhat.com>
AuthorDate: Thu, 5 Aug 2010 17:10:53 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 17 Aug 2010 09:11:10 +0200
lockdep: Remove __debug_show_held_locks
There is no longer any functional difference between
__debug_show_held_locks() and debug_show_held_locks(),
so remove the former.
Signed-off-by: John Kacur <jkacur@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1281021054-4228-1-git-send-email-jkacur@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/debug_locks.h | 5 -----
kernel/hung_task.c | 2 +-
kernel/lockdep.c | 8 +-------
3 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
index 29b3ce3..2833452 100644
--- a/include/linux/debug_locks.h
+++ b/include/linux/debug_locks.h
@@ -49,7 +49,6 @@ struct task_struct;
#ifdef CONFIG_LOCKDEP
extern void debug_show_all_locks(void);
-extern void __debug_show_held_locks(struct task_struct *task);
extern void debug_show_held_locks(struct task_struct *task);
extern void debug_check_no_locks_freed(const void *from, unsigned long len);
extern void debug_check_no_locks_held(struct task_struct *task);
@@ -58,10 +57,6 @@ static inline void debug_show_all_locks(void)
{
}
-static inline void __debug_show_held_locks(struct task_struct *task)
-{
-}
-
static inline void debug_show_held_locks(struct task_struct *task)
{
}
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index 0c642d5..bca9423 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -98,7 +98,7 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
printk(KERN_ERR "\"echo 0 > /proc/sys/kernel/hung_task_timeout_secs\""
" disables this message.\n");
sched_show_task(t);
- __debug_show_held_locks(t);
+ debug_show_held_locks(t);
touch_nmi_watchdog();
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index f2852a5..84baa71 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -3775,7 +3775,7 @@ EXPORT_SYMBOL_GPL(debug_show_all_locks);
* Careful: only use this function if you are sure that
* the task cannot run in parallel!
*/
-void __debug_show_held_locks(struct task_struct *task)
+void debug_show_held_locks(struct task_struct *task)
{
if (unlikely(!debug_locks)) {
printk("INFO: lockdep is turned off.\n");
@@ -3783,12 +3783,6 @@ void __debug_show_held_locks(struct task_struct *task)
}
lockdep_print_held_locks(task);
}
-EXPORT_SYMBOL_GPL(__debug_show_held_locks);
-
-void debug_show_held_locks(struct task_struct *task)
-{
- __debug_show_held_locks(task);
-}
EXPORT_SYMBOL_GPL(debug_show_held_locks);
void lockdep_sys_exit(void)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-17 7:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-05 15:10 [PATCH 1/2] lockdep: Remove __debug_show_held_locks John Kacur
2010-08-05 15:10 ` [PATCH 2/2] [TRIVIAL] fix grammar by adding a missing "to" in the comments John Kacur
2010-08-17 7:55 ` [tip:core/urgent] lockup detector: Fix " tip-bot for John Kacur
2010-08-17 7:55 ` [tip:core/urgent] lockdep: Remove __debug_show_held_locks tip-bot for John Kacur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®