* [PATCH] i386: fix double accounting in reserve_top_address()
@ 2009-07-30 15:49 Jan Beulich
2009-08-04 15:32 ` [tip:x86/urgent] x86, 32-bit: Fix " tip-bot for Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2009-07-30 15:49 UTC (permalink / raw)
To: mingo, tglx, hpa; +Cc: linux-kernel
With VMALLOC_END included in the calculation of MAXMEM (as of 2.6.28)
it is no longer correct to also bump __VMALLOC_RESERVE in
reserve_top_address(). Doing so results in needlessly small lowmem.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/mm/pgtable.c | 1 -
1 file changed, 1 deletion(-)
--- linux-2.6.31-rc4/arch/x86/mm/pgtable.c 2009-07-28 09:36:41.000000000 +0200
+++ 2.6.31-rc4-i386-reserve-top-address/arch/x86/mm/pgtable.c 2009-07-30 17:27:52.000000000 +0200
@@ -329,7 +329,6 @@ void __init reserve_top_address(unsigned
printk(KERN_INFO "Reserving virtual address space above 0x%08x\n",
(int)-reserve);
__FIXADDR_TOP = -reserve - PAGE_SIZE;
- __VMALLOC_RESERVE += reserve;
#endif
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/urgent] x86, 32-bit: Fix double accounting in reserve_top_address()
2009-07-30 15:49 [PATCH] i386: fix double accounting in reserve_top_address() Jan Beulich
@ 2009-08-04 15:32 ` tip-bot for Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jan Beulich @ 2009-08-04 15:32 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, jbeulich, JBeulich, tglx, mingo
Commit-ID: 6abf65510944d33b47575d151c6b318993c8d2b5
Gitweb: http://git.kernel.org/tip/6abf65510944d33b47575d151c6b318993c8d2b5
Author: Jan Beulich <JBeulich@novell.com>
AuthorDate: Thu, 30 Jul 2009 16:49:30 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 4 Aug 2009 16:27:29 +0200
x86, 32-bit: Fix double accounting in reserve_top_address()
With VMALLOC_END included in the calculation of MAXMEM (as of
2.6.28) it is no longer correct to also bump __VMALLOC_RESERVE
in reserve_top_address(). Doing so results in needlessly small
lowmem.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
LKML-Reference: <4A71DD2A020000780000D482@vpn.id2.novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/mm/pgtable.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
index af8f965..ed34f5e 100644
--- a/arch/x86/mm/pgtable.c
+++ b/arch/x86/mm/pgtable.c
@@ -329,7 +329,6 @@ void __init reserve_top_address(unsigned long reserve)
printk(KERN_INFO "Reserving virtual address space above 0x%08x\n",
(int)-reserve);
__FIXADDR_TOP = -reserve - PAGE_SIZE;
- __VMALLOC_RESERVE += reserve;
#endif
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-04 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-30 15:49 [PATCH] i386: fix double accounting in reserve_top_address() Jan Beulich
2009-08-04 15:32 ` [tip:x86/urgent] x86, 32-bit: Fix " tip-bot for Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome