mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [tip:x86/debug] x86/nmi: Fix timeout test in test_nmi_ipi()
       [not found] <20170619105304.GA23995@elgon.mountain>
@ 2017-06-20 13:28 ` tip-bot for Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: tip-bot for Dan Carpenter @ 2017-06-20 13:28 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: dzickus, dan.carpenter, peterz, tglx, mingo, hpa, linux-kernel, torvalds

Commit-ID:  c133c7615751008f6c32ccae7cdfc5ff6e989c35
Gitweb:     http://git.kernel.org/tip/c133c7615751008f6c32ccae7cdfc5ff6e989c35
Author:     Dan Carpenter <dan.carpenter@oracle.com>
AuthorDate: Mon, 19 Jun 2017 13:53:04 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 20 Jun 2017 12:52:43 +0200

x86/nmi: Fix timeout test in test_nmi_ipi()

We're supposed to exit the loop with "timeout" set to zero.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Fixes: 99e8b9ca90d6 ("x86, NMI: Add NMI IPI selftest")
Link: http://lkml.kernel.org/r/20170619105304.GA23995@elgon.mountain
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/nmi_selftest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/nmi_selftest.c b/arch/x86/kernel/nmi_selftest.c
index 6d9582e..d27f8d8 100644
--- a/arch/x86/kernel/nmi_selftest.c
+++ b/arch/x86/kernel/nmi_selftest.c
@@ -78,7 +78,7 @@ static void __init test_nmi_ipi(struct cpumask *mask)
 
 	/* Don't wait longer than a second */
 	timeout = USEC_PER_SEC;
-	while (!cpumask_empty(mask) && timeout--)
+	while (!cpumask_empty(mask) && --timeout)
 	        udelay(1);
 
 	/* What happens if we timeout, do we still unregister?? */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-06-20 13:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20170619105304.GA23995@elgon.mountain>
2017-06-20 13:28 ` [tip:x86/debug] x86/nmi: Fix timeout test in test_nmi_ipi() tip-bot for Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome