* [PATCH] x86/Kconfig: avoid issuing pointless turned off entries to .config
@ 2015-02-05 15:39 Jan Beulich
2015-02-19 0:26 ` [tip:x86/build] x86/Kconfig: Avoid " tip-bot for Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2015-02-05 15:39 UTC (permalink / raw)
To: mingo, tglx, hpa; +Cc: linux-kernel
Settings without prompts shouldn't normally have defaults other than Y,
as otherwise they (a) needlessly enlarge the resulting .config and (b)
if they ever get a prompt added later, the tracked setting of off will
prevent the devloper from then being prompted for his/her choice when
doing an incremental update of the configuration (make oldconfig).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
arch/x86/Kconfig | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
--- 3.19-rc7/arch/x86/Kconfig
+++ 3.19-rc7-x86-Kconfig-cleanup/arch/x86/Kconfig
@@ -232,12 +232,10 @@ config ARCH_WANT_GENERAL_HUGETLB
def_bool y
config ZONE_DMA32
- bool
- default X86_64
+ def_bool y if X86_64
config AUDIT_ARCH
- bool
- default X86_64
+ def_bool y if X86_64
config ARCH_SUPPORTS_OPTIMIZED_INLINING
def_bool y
@@ -1110,10 +1108,10 @@ config MICROCODE_OLD_INTERFACE
depends on MICROCODE
config MICROCODE_INTEL_EARLY
- def_bool n
+ bool
config MICROCODE_AMD_EARLY
- def_bool n
+ bool
config MICROCODE_EARLY
bool "Early load microcode"
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/build] x86/Kconfig: Avoid issuing pointless turned off entries to .config
2015-02-05 15:39 [PATCH] x86/Kconfig: avoid issuing pointless turned off entries to .config Jan Beulich
@ 2015-02-19 0:26 ` tip-bot for Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jan Beulich @ 2015-02-19 0:26 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, jbeulich, tglx, mingo, JBeulich
Commit-ID: e0fd24a3b4ad7b4084b41944835952eedec53f98
Gitweb: http://git.kernel.org/tip/e0fd24a3b4ad7b4084b41944835952eedec53f98
Author: Jan Beulich <JBeulich@suse.com>
AuthorDate: Thu, 5 Feb 2015 15:39:34 +0000
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 18 Feb 2015 22:08:46 +0100
x86/Kconfig: Avoid issuing pointless turned off entries to .config
Settings without prompts shouldn't normally have defaults other
than Y, as otherwise they (a) needlessly enlarge the resulting
.config and (b) if they ever get a prompt added later, the
tracked setting of off will prevent the devloper from then being
prompted for his/her choice when doing an incremental update of
the configuration (make oldconfig).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Link: http://lkml.kernel.org/r/54D39CC6020000780005D6AE@mail.emea.novell.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/Kconfig | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5e28e2b..463d883 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -233,12 +233,10 @@ config ARCH_WANT_GENERAL_HUGETLB
def_bool y
config ZONE_DMA32
- bool
- default X86_64
+ def_bool y if X86_64
config AUDIT_ARCH
- bool
- default X86_64
+ def_bool y if X86_64
config ARCH_SUPPORTS_OPTIMIZED_INLINING
def_bool y
@@ -1115,10 +1113,10 @@ config MICROCODE_OLD_INTERFACE
depends on MICROCODE
config MICROCODE_INTEL_EARLY
- def_bool n
+ bool
config MICROCODE_AMD_EARLY
- def_bool n
+ bool
config MICROCODE_EARLY
bool "Early load microcode"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-19 0:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05 15:39 [PATCH] x86/Kconfig: avoid issuing pointless turned off entries to .config Jan Beulich
2015-02-19 0:26 ` [tip:x86/build] x86/Kconfig: Avoid " tip-bot for Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome