Re: kmemleak_scan_area

[Sachin Pandhare <sachinpandhare@gmail.com>]

On Wed, Mar 31, 2010 at 5:36 PM, Catalin Marinas
<catalin.marinas@arm.com> wrote:
> Sachin Pandhare <sachinpandhare@gmail.com> wrote:
>> In kmemleak.c file "kmemleak_scan_area" is appearing as a structure as
>> well as a function.
>> e.g.:
>> - struct kmemleak_scan_area {
>> - void __ref kmemleak_scan_area(const void *ptr, size_t size, gfp_t gfp)
>>
>> Do you think it is a good to have it like that?
>
> Does it cause any problems? I think C has different namespaces for types
> and functions, so they should not collide. I agree that from a
> readability perspective, it would be better if they are named
> differently (like kmemleak_scan_area_node :)).

It has not caused any problem.
Thanks,

>
> --
> Catalin