* [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()
@ 2020-09-16 6:21 Qinglang Miao
2020-09-16 9:15 ` [EXT] " Manish Rangankar
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Qinglang Miao @ 2020-09-16 6:21 UTC (permalink / raw)
To: Nilesh Javali, Manish Rangankar, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel, Qinglang Miao
The mutex bnx2i_dev_lock is initialized statically. It is
unnecessary to initialize by mutex_init().
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/scsi/bnx2i/bnx2i_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
index 6018cdd17..2b3f0c104 100644
--- a/drivers/scsi/bnx2i/bnx2i_init.c
+++ b/drivers/scsi/bnx2i/bnx2i_init.c
@@ -474,8 +474,6 @@ static int __init bnx2i_mod_init(void)
if (sq_size && !is_power_of_2(sq_size))
sq_size = roundup_pow_of_two(sq_size);
- mutex_init(&bnx2i_dev_lock);
-
bnx2i_scsi_xport_template =
iscsi_register_transport(&bnx2i_iscsi_transport);
if (!bnx2i_scsi_xport_template) {
--
2.23.0
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()
2020-09-16 6:21 [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init() Qinglang Miao
@ 2020-09-16 9:15 ` Manish Rangankar
2020-09-23 0:29 ` Martin K. Petersen
2020-09-30 3:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Manish Rangankar @ 2020-09-16 9:15 UTC (permalink / raw)
To: Qinglang Miao, Nilesh Javali, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel, GR-QLogic-Storage-Upstream
> -----Original Message-----
> From: Qinglang Miao <miaoqinglang@huawei.com>
> Sent: Wednesday, September 16, 2020 11:52 AM
> To: Nilesh Javali <njavali@marvell.com>; Manish Rangankar
> <mrangankar@marvell.com>; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@marvell.com>; James E.J. Bottomley
> <jejb@linux.ibm.com>; Martin K. Petersen <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Qinglang Miao
> <miaoqinglang@huawei.com>
> Subject: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()
>
> External Email
>
> ----------------------------------------------------------------------
> The mutex bnx2i_dev_lock is initialized statically. It is unnecessary to
> initialize by mutex_init().
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> drivers/scsi/bnx2i/bnx2i_init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
> index 6018cdd17..2b3f0c104 100644
> --- a/drivers/scsi/bnx2i/bnx2i_init.c
> +++ b/drivers/scsi/bnx2i/bnx2i_init.c
> @@ -474,8 +474,6 @@ static int __init bnx2i_mod_init(void)
> if (sq_size && !is_power_of_2(sq_size))
> sq_size = roundup_pow_of_two(sq_size);
>
> - mutex_init(&bnx2i_dev_lock);
> -
> bnx2i_scsi_xport_template =
> iscsi_register_transport(&bnx2i_iscsi_transport);
> if (!bnx2i_scsi_xport_template) {
> --
Thanks,
Acked-by: Manish Rangankar <mrangankar@marvell.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()
2020-09-16 6:21 [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init() Qinglang Miao
2020-09-16 9:15 ` [EXT] " Manish Rangankar
@ 2020-09-23 0:29 ` Martin K. Petersen
2020-09-30 3:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-09-23 0:29 UTC (permalink / raw)
To: Qinglang Miao
Cc: Nilesh Javali, Manish Rangankar, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
Qinglang,
> The mutex bnx2i_dev_lock is initialized statically. It is
> unnecessary to initialize by mutex_init().
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()
2020-09-16 6:21 [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init() Qinglang Miao
2020-09-16 9:15 ` [EXT] " Manish Rangankar
2020-09-23 0:29 ` Martin K. Petersen
@ 2020-09-30 3:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-09-30 3:34 UTC (permalink / raw)
To: Manish Rangankar, GR-QLogic-Storage-Upstream, Nilesh Javali,
Qinglang Miao, James E.J. Bottomley
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Wed, 16 Sep 2020 14:21:33 +0800, Qinglang Miao wrote:
> The mutex bnx2i_dev_lock is initialized statically. It is
> unnecessary to initialize by mutex_init().
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: bnx2i: Remove unnecessary mutex_init()
https://git.kernel.org/mkp/scsi/c/97d0e04d38b4
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-30 3:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 6:21 [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init() Qinglang Miao
2020-09-16 9:15 ` [EXT] " Manish Rangankar
2020-09-23 0:29 ` Martin K. Petersen
2020-09-30 3:34 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®