[PATCH] scsi: pmcraid: Convert comma to semicolon

[PATCH] scsi: pmcraid: Convert comma to semicolon

[Chen Ni]

Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/scsi/pmcraid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index a2a084c8075e..8f7307c4d876 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -1946,7 +1946,7 @@ static void pmcraid_soft_reset(struct pmcraid_cmd *cmd)
 	}
 
 	iowrite32(doorbell, pinstance->int_regs.host_ioa_interrupt_reg);
-	ioread32(pinstance->int_regs.host_ioa_interrupt_reg),
+	ioread32(pinstance->int_regs.host_ioa_interrupt_reg);
 	int_reg = ioread32(pinstance->int_regs.ioa_host_interrupt_reg);
 
 	pmcraid_info("Waiting for IOA to become operational %x:%x\n",
-- 
2.25.1

Re: [PATCH] scsi: pmcraid: Convert comma to semicolon

[Martin K. Petersen]

Chen,

> Replace comma between expressions with semicolons.

Applied to 6.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: pmcraid: Convert comma to semicolon

[Martin K. Petersen]

On Thu, 05 Sep 2024 10:35:21 +0800, Chen Ni wrote:

> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> [...]

Applied to 6.12/scsi-queue, thanks!

[1/1] scsi: pmcraid: Convert comma to semicolon
      https://git.kernel.org/mkp/scsi/c/4708c9332d97

-- 
Martin K. Petersen	Oracle Linux Engineering