* [PATCH] scsi: pmcraid: Convert comma to semicolon
@ 2024-09-05 2:35 Chen Ni
2024-09-13 0:42 ` Martin K. Petersen
2024-09-19 15:52 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2024-09-05 2:35 UTC (permalink / raw)
To: James.Bottomley, martin.petersen; +Cc: linux-scsi, linux-kernel, Chen Ni
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/scsi/pmcraid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index a2a084c8075e..8f7307c4d876 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -1946,7 +1946,7 @@ static void pmcraid_soft_reset(struct pmcraid_cmd *cmd)
}
iowrite32(doorbell, pinstance->int_regs.host_ioa_interrupt_reg);
- ioread32(pinstance->int_regs.host_ioa_interrupt_reg),
+ ioread32(pinstance->int_regs.host_ioa_interrupt_reg);
int_reg = ioread32(pinstance->int_regs.ioa_host_interrupt_reg);
pmcraid_info("Waiting for IOA to become operational %x:%x\n",
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: pmcraid: Convert comma to semicolon
2024-09-05 2:35 [PATCH] scsi: pmcraid: Convert comma to semicolon Chen Ni
@ 2024-09-13 0:42 ` Martin K. Petersen
2024-09-19 15:52 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2024-09-13 0:42 UTC (permalink / raw)
To: Chen Ni; +Cc: James.Bottomley, martin.petersen, linux-scsi, linux-kernel
Chen,
> Replace comma between expressions with semicolons.
Applied to 6.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: pmcraid: Convert comma to semicolon
2024-09-05 2:35 [PATCH] scsi: pmcraid: Convert comma to semicolon Chen Ni
2024-09-13 0:42 ` Martin K. Petersen
@ 2024-09-19 15:52 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2024-09-19 15:52 UTC (permalink / raw)
To: James.Bottomley, Chen Ni; +Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Thu, 05 Sep 2024 10:35:21 +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> [...]
Applied to 6.12/scsi-queue, thanks!
[1/1] scsi: pmcraid: Convert comma to semicolon
https://git.kernel.org/mkp/scsi/c/4708c9332d97
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-19 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-05 2:35 [PATCH] scsi: pmcraid: Convert comma to semicolon Chen Ni
2024-09-13 0:42 ` Martin K. Petersen
2024-09-19 15:52 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome