* [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform
@ 2016-01-27 16:48 Nicolas Ferre
2016-01-28 16:00 ` Måns Rullgård
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Ferre @ 2016-01-27 16:48 UTC (permalink / raw)
To: linux-arm-kernel, broonie
Cc: linux-kernel, Cyrille Pitchen, Wenyou Yang, mans, linux-spi,
stable, Nicolas Ferre
From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
The non-DT platform that uses this driver (actually the AVR32) was taking a bad
branch for determining if the IP would use gpio for CS.
Adding the presence of DT as a condition fixes this issue.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
[nicolas.ferre@atmel.com: extract from ml discussion]
Reported-by: Mans Rullgard <mans@mansr.com>
Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller")
Cc: <stable@vger.kernel.org> # 4.2+
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
drivers/spi/spi-atmel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index aebad36391c9..8feac599e9ab 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -1571,6 +1571,7 @@ static int atmel_spi_probe(struct platform_device *pdev)
as->use_cs_gpios = true;
if (atmel_spi_is_v2(as) &&
+ pdev->dev.of_node &&
!of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
as->use_cs_gpios = false;
master->num_chipselect = 4;
--
2.1.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform
2016-01-27 16:48 [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform Nicolas Ferre
@ 2016-01-28 16:00 ` Måns Rullgård
0 siblings, 0 replies; 2+ messages in thread
From: Måns Rullgård @ 2016-01-28 16:00 UTC (permalink / raw)
To: Nicolas Ferre
Cc: linux-arm-kernel, broonie, linux-kernel, Cyrille Pitchen,
Wenyou Yang, linux-spi, stable
Nicolas Ferre <nicolas.ferre@atmel.com> writes:
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>
> The non-DT platform that uses this driver (actually the AVR32) was taking a bad
> branch for determining if the IP would use gpio for CS.
> Adding the presence of DT as a condition fixes this issue.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> [nicolas.ferre@atmel.com: extract from ml discussion]
> Reported-by: Mans Rullgard <mans@mansr.com>
> Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller")
> Cc: <stable@vger.kernel.org> # 4.2+
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Tested-by: Mans Rullgard <mans@mansr.com>
> ---
> drivers/spi/spi-atmel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index aebad36391c9..8feac599e9ab 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1571,6 +1571,7 @@ static int atmel_spi_probe(struct platform_device *pdev)
>
> as->use_cs_gpios = true;
> if (atmel_spi_is_v2(as) &&
> + pdev->dev.of_node &&
> !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
> as->use_cs_gpios = false;
> master->num_chipselect = 4;
> --
> 2.1.3
>
--
Måns Rullgård
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-28 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-27 16:48 [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform Nicolas Ferre
2016-01-28 16:00 ` Måns Rullgård
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®