From: "Måns Rullgård" <mans@mansr.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Sebastian Frias <sf84@laposte.net>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, mason <slash.tmp@free.fr>
Subject: Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver
Date: Fri, 05 Feb 2016 15:58:42 +0000 [thread overview]
Message-ID: <yw1x7fijgnd9.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <CAHp75Vc0nW5EuLD7-ZmB5e63vvFLdmjfbd4a1nAweeTGOs795Q@mail.gmail.com> (Andy Shevchenko's message of "Fri, 5 Feb 2016 17:57:56 +0200")
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> On Fri, Feb 5, 2016 at 3:39 PM, Måns Rullgård <mans@mansr.com> wrote:
>>> + if (ret < 0) {
>>> + dev_err(&pdev->dev, "broken fixed-link specification\n");
>>
>> Line is longer than 80 chars.
>
> This is actually okay, though I would recommend to move long string
> literal to the next line.
I only mentioned it because fixing it was trivial.
--
Måns Rullgård
prev parent reply other threads:[~2016-02-05 15:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 13:31 Sebastian Frias
2016-02-05 13:39 ` Måns Rullgård
2016-02-05 13:49 ` [PATCH v2] net: ethernet: support "fixed-link" DT key/node " Sebastian Frias
2016-02-05 13:58 ` Måns Rullgård
2016-02-05 14:08 ` Sebastian Frias
2016-02-05 14:13 ` Måns Rullgård
2016-02-05 14:22 ` [PATCH v3] net: ethernet: support "fixed-link" DT node " Sebastian Frias
2016-02-05 14:34 ` Måns Rullgård
2016-02-05 14:56 ` Sebastian Frias
2016-02-05 15:08 ` Måns Rullgård
2016-02-05 15:20 ` Sebastian Frias
2016-02-05 15:26 ` Måns Rullgård
2016-02-08 10:23 ` [PATCH v5] net: ethernet: nb8800: support fixed-link DT node Sebastian Frias
2016-02-08 13:19 ` Måns Rullgård
2016-02-16 20:04 ` David Miller
2016-02-08 10:34 ` [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias
2016-02-08 13:37 ` Måns Rullgård
2016-02-08 14:11 ` Mason
2016-02-08 14:38 ` Sebastian Frias
2016-02-08 14:44 ` Måns Rullgård
2016-02-08 14:32 ` Sebastian Frias
2016-02-08 14:50 ` Måns Rullgård
2016-02-05 14:56 ` [PATCH v4] net: ethernet: nb8800: support fixed-link DT node Sebastian Frias
2016-02-05 15:57 ` [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Andy Shevchenko
2016-02-05 15:58 ` Måns Rullgård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1x7fijgnd9.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sf84@laposte.net \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®