mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Måns Rullgård" <mans@mansr.com>
To: Sebastian Frias <sf84@laposte.net>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	mason <slash.tmp@free.fr>
Subject: Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver
Date: Mon, 08 Feb 2016 14:50:38 +0000	[thread overview]
Message-ID: <yw1xzivbdznl.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <56B8A6F5.9060409@laposte.net> (Sebastian Frias's message of "Mon, 08 Feb 2016 15:32:21 +0100")

Sebastian Frias <sf84@laposte.net> writes:

>>> By the way, I know some people like the command line, email, etc. but
>>> there ought to be other tools better suited for patch review...
>>
>> Some kernel subsystems use http://patchwork.ozlabs.org/ to track status
>> of various patches.
>>
>
> Thanks, I see that netdev is part of it, and that the patches are there:
>
> https://patchwork.ozlabs.org/patch/580217/
>
> seems like a slight layer over plain email and mailinglists; I was
> thinking of something more in the line of
> https://www.gerritcodereview.com/
> I believe Google uses Gerrit for Android.
> I think Gerrit would probably be too big (and being written in Java,
> using Prolog and other DSLs, implementing its own Git server in Java,
> etc, may make some -or lots?- of kernel developers cry :-) )
> However, in Gerrit it is easier to know where in the "review" process
> we are, because people have to explicitly give a score "+/- X" when
> commenting on a patch.
> Also, the diff can operate between different versions of the patches
> themselves to see if the inlined comments were addressed.

Gerrit has some merits, but for seasoned developers it's largely a
nuisance.  It's probably good at keeping junior/undisciplined developers
from doing too much damage by strictly enforcing a cumbersome process.

-- 
Måns Rullgård

  reply	other threads:[~2016-02-08 14:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 13:31 [PATCH] " Sebastian Frias
2016-02-05 13:39 ` Måns Rullgård
2016-02-05 13:49   ` [PATCH v2] net: ethernet: support "fixed-link" DT key/node " Sebastian Frias
2016-02-05 13:58     ` Måns Rullgård
2016-02-05 14:08       ` Sebastian Frias
2016-02-05 14:13         ` Måns Rullgård
2016-02-05 14:22           ` [PATCH v3] net: ethernet: support "fixed-link" DT node " Sebastian Frias
2016-02-05 14:34             ` Måns Rullgård
2016-02-05 14:56               ` Sebastian Frias
2016-02-05 15:08                 ` Måns Rullgård
2016-02-05 15:20                   ` Sebastian Frias
2016-02-05 15:26                     ` Måns Rullgård
2016-02-08 10:23                       ` [PATCH v5] net: ethernet: nb8800: support fixed-link DT node Sebastian Frias
2016-02-08 13:19                         ` Måns Rullgård
2016-02-16 20:04                         ` David Miller
2016-02-08 10:34                       ` [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias
2016-02-08 13:37                         ` Måns Rullgård
2016-02-08 14:11                           ` Mason
2016-02-08 14:38                             ` Sebastian Frias
2016-02-08 14:44                               ` Måns Rullgård
2016-02-08 14:32                           ` Sebastian Frias
2016-02-08 14:50                             ` Måns Rullgård [this message]
2016-02-05 14:56               ` [PATCH v4] net: ethernet: nb8800: support fixed-link DT node Sebastian Frias
2016-02-05 15:57   ` [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Andy Shevchenko
2016-02-05 15:58     ` Måns Rullgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yw1xzivbdznl.fsf@unicorn.mansr.com \
    --to=mans@mansr.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sf84@laposte.net \
    --cc=slash.tmp@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®