shmem_file_setup not exported

shmem_file_setup not exported

[Måns Rullgård]

I noticed this change in mm/shmem.c:

-EXPORT_SYMBOL(shmem_file_setup);

Is there a reason for this, other than nobody using it?

I used that function in a module I wrote, mostly as a proof of
concept, for someone who was looking for a way to unmap memory pages
while retaining their contents, and being able to map them later.

-- 
Måns Rullgård
mru@inprovide.com

Re: shmem_file_setup not exported

[Hugh Dickins]

On Sat, 6 Nov 2004, Måns Rullgård wrote:
> I noticed this change in mm/shmem.c:
> 
> -EXPORT_SYMBOL(shmem_file_setup);
> 
> Is there a reason for this, other than nobody using it?

That's the reason hch rightly removed the export, yes.
ipc/shm.c does use it, but it's never a module, so doesn't need export.
No other reason, beyond that it's appropriate to minimize exports.
If you want to use it from your module, just patch the export back.

Hugh

Re: shmem_file_setup not exported

[Måns Rullgård]

Hugh Dickins <hugh@veritas.com> writes:

> On Sat, 6 Nov 2004, Måns Rullgård wrote:
>> I noticed this change in mm/shmem.c:
>> 
>> -EXPORT_SYMBOL(shmem_file_setup);
>> 
>> Is there a reason for this, other than nobody using it?
>
> That's the reason hch rightly removed the export, yes.
> ipc/shm.c does use it, but it's never a module, so doesn't need export.
> No other reason, beyond that it's appropriate to minimize exports.
> If you want to use it from your module, just patch the export back.

That makes using the module more complicated.  I don't really care
much, I'm not actively using the module.  I was just wondering whether
using it was incredibly silly for some reason.

-- 
Måns Rullgård
mru@inprovide.com