Re: [PATCH v3 8/9] reset: amlogic: split the device core and platform probe

From: Philipp Zabel <p.zabel@pengutronix.de>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Neil Armstrong <neil.armstrong@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
	linux-kernel@vger.kernel.org,  linux-amlogic@lists.infradead.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 8/9] reset: amlogic: split the device core and platform probe
Date: Mon, 02 Sep 2024 11:47:34 +0200	[thread overview]
Message-ID: <34bc2d1ceef7bcab3d9b78de588e996c2d2ecdd3.camel@pengutronix.de> (raw)
In-Reply-To: <1jsev0wj8y.fsf@starbuckisacylon.baylibre.com>

On Mo, 2024-08-19 at 18:49 +0200, Jerome Brunet wrote:
> On Mon 19 Aug 2024 at 18:33, Neil Armstrong <neil.armstrong@linaro.org> wrote:
> 
> > On 08/08/2024 12:27, Jerome Brunet wrote:
> > > To prepare the addition of the auxiliary device support, split
> > > out the device core function from the probe of the platform device.
> > > The device core function will be common to both the platform and
> > > auxiliary
> > > driver.
> > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > > ---
> > >   drivers/reset/amlogic/Kconfig                 |  10 +-
> > >   drivers/reset/amlogic/Makefile                |   3 +-
> > >   .../{reset-meson.c => reset-meson-core.c}     | 101 +++---------------
> > >   drivers/reset/amlogic/reset-meson-pltf.c      |  92 ++++++++++++++++
> > 
> > Are we still in 1983 ?
> 
> I don't quite get that remark or how it is helping the review.
>
> > please use reset-meson-platform and drop pltf completely
> 
> You are requesting auxiliary -> aux on the patch.
> So which one will it be ?

I would prefer to drop the -pltf suffix completely and also to drop the
"reset driver" -> "reset platform driver" documentation changes.

regards
Philipp

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic