Re: [PATCH v3 3/9] reset: amlogic: make parameters unsigned

From: Neil Armstrong <neil.armstrong@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 3/9] reset: amlogic: make parameters unsigned
Date: Mon, 19 Aug 2024 18:29:30 +0200	[thread overview]
Message-ID: <b828b63d-e1a8-4c9b-9001-da686dffeb64@linaro.org> (raw)
In-Reply-To: <20240808102742.4095904-4-jbrunet@baylibre.com>

On 08/08/2024 12:27, Jerome Brunet wrote:
> register count and offset cannot be negative. Use unsigned integer
> for this.
> 
> Suggested-by: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>   drivers/reset/reset-meson.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
> index 820905779acd..460ad2f8360f 100644
> --- a/drivers/reset/reset-meson.c
> +++ b/drivers/reset/reset-meson.c
> @@ -17,8 +17,8 @@
>   #include <linux/types.h>
>   
>   struct meson_reset_param {
> -	int reg_count;
> -	int level_offset;
> +	unsigned int reg_count;
> +	unsigned int level_offset;
>   };
>   
>   struct meson_reset {

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic