From: Neil Armstrong <neil.armstrong@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 2/9] reset: amlogic: use generic data matching function
Date: Mon, 19 Aug 2024 18:29:22 +0200 [thread overview]
Message-ID: <8cae4536-52ff-4e54-ba15-6376dd9129ca@linaro.org> (raw)
In-Reply-To: <20240808102742.4095904-3-jbrunet@baylibre.com>
On 08/08/2024 12:27, Jerome Brunet wrote:
> There is no need to use the DT specific function to get
> matching data, use the generic one instead
>
> Suggested-by: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/reset/reset-meson.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
> index b47431a21b86..820905779acd 100644
> --- a/drivers/reset/reset-meson.c
> +++ b/drivers/reset/reset-meson.c
> @@ -128,7 +128,7 @@ static int meson_reset_probe(struct platform_device *pdev)
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> - data->param = of_device_get_match_data(dev);
> + data->param = device_get_match_data(dev);
> if (!data->param)
> return -ENODEV;
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-08-19 16:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 10:27 [PATCH v3 0/9] reset: amlogic: move audio reset drivers out of CCF Jerome Brunet
2024-08-08 10:27 ` [PATCH v3 1/9] reset: amlogic: convert driver to regmap Jerome Brunet
2024-08-19 15:55 ` Neil Armstrong
2024-08-08 10:27 ` [PATCH v3 2/9] reset: amlogic: use generic data matching function Jerome Brunet
2024-08-19 16:29 ` Neil Armstrong [this message]
2024-08-08 10:27 ` [PATCH v3 3/9] reset: amlogic: make parameters unsigned Jerome Brunet
2024-08-19 16:29 ` Neil Armstrong
2024-08-08 10:27 ` [PATCH v3 4/9] reset: amlogic: add driver parameters Jerome Brunet
2024-08-19 15:57 ` Neil Armstrong
2024-08-19 16:40 ` Jerome Brunet
2024-08-19 17:03 ` Neil Armstrong
2024-08-08 10:27 ` [PATCH v3 5/9] reset: amlogic: use reset number instead of register count Jerome Brunet
2024-08-19 16:30 ` Neil Armstrong
2024-08-08 10:27 ` [PATCH v3 6/9] reset: amlogic: add reset status support Jerome Brunet
2024-08-19 16:31 ` Neil Armstrong
2024-08-08 10:27 ` [PATCH v3 7/9] reset: amlogic: move drivers to a dedicated directory Jerome Brunet
2024-08-19 16:31 ` Neil Armstrong
2024-08-08 10:27 ` [PATCH v3 8/9] reset: amlogic: split the device core and platform probe Jerome Brunet
2024-08-19 16:33 ` Neil Armstrong
2024-08-19 16:49 ` Jerome Brunet
2024-08-19 16:57 ` Neil Armstrong
2024-09-02 9:47 ` Philipp Zabel
2024-09-02 9:53 ` Jerome Brunet
2024-09-02 10:40 ` Philipp Zabel
2024-09-02 10:37 ` Philipp Zabel
2024-08-08 10:27 ` [PATCH v3 9/9] reset: amlogic: add auxiliary reset driver support Jerome Brunet
2024-08-19 16:35 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cae4536-52ff-4e54-ba15-6376dd9129ca@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®