mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
* [PATCH v2 0/6] arm64: dts: small .dts fixes
@ 2023-01-11 21:13 Martin Blumenstingl
  2023-01-11 21:13 ` [PATCH v2 1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node Martin Blumenstingl
                   ` (6 more replies)
  0 siblings, 7 replies; 15+ messages in thread
From: Martin Blumenstingl @ 2023-01-11 21:13 UTC (permalink / raw)
  To: linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, neil.armstrong, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Martin Blumenstingl

This series contains a few .dts fixes which were found during review of
[0] (which is now the first patch in this series).



[0] https://lore.kernel.org/linux-amlogic/20230110215926.1296650-1-martin.blumenstingl@googlemail.com/


Martin Blumenstingl (6):
  arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node
  arm64: dts: meson-gxl: jethub-j80: Fix Bluetooth MAC node name
  arm64: dts: meson-axg: jethub-j1xx: Fix MAC address node names
  arm64: dts: meson-gx: Fix Ethernet MAC address unit name
  arm64: dts: meson-g12a: Fix internal Ethernet PHY unit name
  arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address

 .../boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi     | 6 +++---
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi           | 2 +-
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi                   | 4 ++--
 .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

-- 
2.39.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node
  2023-01-11 21:13 [PATCH v2 0/6] arm64: dts: small .dts fixes Martin Blumenstingl
@ 2023-01-11 21:13 ` Martin Blumenstingl
  2023-01-13  7:58   ` neil.armstrong
  2023-01-11 21:13 ` [PATCH v2 2/6] arm64: dts: meson-gxl: jethub-j80: Fix Bluetooth MAC node name Martin Blumenstingl
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 15+ messages in thread
From: Martin Blumenstingl @ 2023-01-11 21:13 UTC (permalink / raw)
  To: linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, neil.armstrong, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Martin Blumenstingl,
	Vyacheslav Bocharov

Unit addresses should be written using lower-case hex characters. Use
wifi_mac@c to fix a yaml schema validation error once the eFuse
dt-bindings have been converted to a yaml schema:
  efuse: Unevaluated properties are not allowed ('wifi_mac@C' was
  unexpected)

Also node names should use hyphens instead of underscores as the latter
can also cause warnings.

Fixes: abfaae24ecf3 ("arm64: dts: meson-gxl: add support for JetHub H1")
Acked-by: Vyacheslav Bocharov <adeep@lexina.in>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
changes from v1 -> v2:
- Added Vyacheslav's Acked-by (originally given as "Vyachesav", but my
  understanding is that this was a typo
- Also replace the underscore in the node name with a hyphen

 .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
index 6831137c5c10..270483e007bc 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
@@ -90,7 +90,7 @@ bt_mac: bt_mac@6 {
 		reg = <0x6 0x6>;
 	};
 
-	wifi_mac: wifi_mac@C {
+	wifi_mac: wifi-mac@c {
 		reg = <0xc 0x6>;
 	};
 };
-- 
2.39.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 2/6] arm64: dts: meson-gxl: jethub-j80: Fix Bluetooth MAC node name
  2023-01-11 21:13 [PATCH v2 0/6] arm64: dts: small .dts fixes Martin Blumenstingl
  2023-01-11 21:13 ` [PATCH v2 1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node Martin Blumenstingl
@ 2023-01-11 21:13 ` Martin Blumenstingl
  2023-01-13  7:58   ` neil.armstrong
  2023-01-11 21:13 ` [PATCH v2 3/6] arm64: dts: meson-axg: jethub-j1xx: Fix MAC address node names Martin Blumenstingl
                   ` (4 subsequent siblings)
  6 siblings, 1 reply; 15+ messages in thread
From: Martin Blumenstingl @ 2023-01-11 21:13 UTC (permalink / raw)
  To: linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, neil.armstrong, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Martin Blumenstingl,
	Vyacheslav Bocharov

Node names should use hyphens instead of underscores to not cause
warnings.

Fixes: abfaae24ecf3 ("arm64: dts: meson-gxl: add support for JetHub H1")
Suggested-by: Vyacheslav Bocharov <adeep@lexina.in>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
changes from v1 -> v2:
- new patch

 .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
index 270483e007bc..bb7412070cb2 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
@@ -86,7 +86,7 @@ sdio_pwrseq: sdio-pwrseq {
 };
 
 &efuse {
-	bt_mac: bt_mac@6 {
+	bt_mac: bt-mac@6 {
 		reg = <0x6 0x6>;
 	};
 
-- 
2.39.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 3/6] arm64: dts: meson-axg: jethub-j1xx: Fix MAC address node names
  2023-01-11 21:13 [PATCH v2 0/6] arm64: dts: small .dts fixes Martin Blumenstingl
  2023-01-11 21:13 ` [PATCH v2 1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node Martin Blumenstingl
  2023-01-11 21:13 ` [PATCH v2 2/6] arm64: dts: meson-gxl: jethub-j80: Fix Bluetooth MAC node name Martin Blumenstingl
@ 2023-01-11 21:13 ` Martin Blumenstingl
  2023-01-13  7:59   ` neil.armstrong
  2023-01-11 21:13 ` [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name Martin Blumenstingl
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 15+ messages in thread
From: Martin Blumenstingl @ 2023-01-11 21:13 UTC (permalink / raw)
  To: linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, neil.armstrong, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Martin Blumenstingl

Node names should use hyphens instead of underscores to not cause
warnings.

Fixes: 59ec069d5055 ("arm64: dts: meson-axg: add support for JetHub D1p (j110)")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
changes from v1 -> v2:
- new patch

 .../boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
index 5836b0030931..22fd43b5fd73 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
@@ -168,15 +168,15 @@ sn: sn@32 {
 		reg = <0x32 0x20>;
 	};
 
-	eth_mac: eth_mac@0 {
+	eth_mac: eth-mac@0 {
 		reg = <0x0 0x6>;
 	};
 
-	bt_mac: bt_mac@6 {
+	bt_mac: bt-mac@6 {
 		reg = <0x6 0x6>;
 	};
 
-	wifi_mac: wifi_mac@c {
+	wifi_mac: wifi-mac@c {
 		reg = <0xc 0x6>;
 	};
 
-- 
2.39.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name
  2023-01-11 21:13 [PATCH v2 0/6] arm64: dts: small .dts fixes Martin Blumenstingl
                   ` (2 preceding siblings ...)
  2023-01-11 21:13 ` [PATCH v2 3/6] arm64: dts: meson-axg: jethub-j1xx: Fix MAC address node names Martin Blumenstingl
@ 2023-01-11 21:13 ` Martin Blumenstingl
  2023-01-13  7:59   ` neil.armstrong
  2023-01-13  7:59   ` neil.armstrong
  2023-01-11 21:13 ` [PATCH v2 5/6] arm64: dts: meson-g12a: Fix internal Ethernet PHY " Martin Blumenstingl
                   ` (2 subsequent siblings)
  6 siblings, 2 replies; 15+ messages in thread
From: Martin Blumenstingl @ 2023-01-11 21:13 UTC (permalink / raw)
  To: linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, neil.armstrong, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Martin Blumenstingl,
	Vyacheslav Bocharov

Unit names should use hyphens instead of underscores to not cause
warnings.

Fixes: bfe59f92d306 ("ARM64: dts: amlogic: gxbb: Enable NVMEM")
Suggested-by: Vyacheslav Bocharov <adeep@lexina.in>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
changes from v1 -> v2:
- new patch

 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index e3c12e0be99d..f8b115cd6775 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -233,7 +233,7 @@ sn: sn@14 {
 			reg = <0x14 0x10>;
 		};
 
-		eth_mac: eth_mac@34 {
+		eth_mac: eth-mac@34 {
 			reg = <0x34 0x10>;
 		};
 
-- 
2.39.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 5/6] arm64: dts: meson-g12a: Fix internal Ethernet PHY unit name
  2023-01-11 21:13 [PATCH v2 0/6] arm64: dts: small .dts fixes Martin Blumenstingl
                   ` (3 preceding siblings ...)
  2023-01-11 21:13 ` [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name Martin Blumenstingl
@ 2023-01-11 21:13 ` Martin Blumenstingl
  2023-01-13  7:59   ` neil.armstrong
  2023-01-11 21:13 ` [PATCH v2 6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address Martin Blumenstingl
  2023-01-13  8:03 ` [PATCH v2 0/6] arm64: dts: small .dts fixes Neil Armstrong
  6 siblings, 1 reply; 15+ messages in thread
From: Martin Blumenstingl @ 2023-01-11 21:13 UTC (permalink / raw)
  To: linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, neil.armstrong, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Martin Blumenstingl

Documentation/devicetree/bindings/net/ethernet-phy.yaml defines that the
node name for Ethernet PHYs should match the following pattern:
  ^ethernet-phy(@[a-f0-9]+)?$

Replace the underscore with a hyphen to adhere to this binding.

Fixes: 280c17df8fbf ("arm64: dts: meson: g12a: add mdio multiplexer")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
changes from v1 -> v2:
- new patch

 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index 9dbd50820b1c..c95cf3afc666 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -1694,7 +1694,7 @@ int_mdio: mdio@1 {
 					#address-cells = <1>;
 					#size-cells = <0>;
 
-					internal_ephy: ethernet_phy@8 {
+					internal_ephy: ethernet-phy@8 {
 						compatible = "ethernet-phy-id0180.3301",
 							     "ethernet-phy-ieee802.3-c22";
 						interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.39.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address
  2023-01-11 21:13 [PATCH v2 0/6] arm64: dts: small .dts fixes Martin Blumenstingl
                   ` (4 preceding siblings ...)
  2023-01-11 21:13 ` [PATCH v2 5/6] arm64: dts: meson-g12a: Fix internal Ethernet PHY " Martin Blumenstingl
@ 2023-01-11 21:13 ` Martin Blumenstingl
  2023-01-13  7:59   ` neil.armstrong
  2023-01-13  8:03 ` [PATCH v2 0/6] arm64: dts: small .dts fixes Neil Armstrong
  6 siblings, 1 reply; 15+ messages in thread
From: Martin Blumenstingl @ 2023-01-11 21:13 UTC (permalink / raw)
  To: linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, neil.armstrong, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Martin Blumenstingl

Node names should be generic and use hyphens instead of underscores to
not cause warnings. Also nodes without a reg property should not have a
unit-address. Change the scpi_dvfs node to use clock-controller as node
name without a unit address (since it does not have a reg property).

Fixes: 70db166a2baa ("ARM64: dts: meson-gxbb: Add SCPI with cpufreq & sensors Nodes")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
changes from v1 -> v2:
- new patch

 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index f8b115cd6775..a79a35e84281 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -250,7 +250,7 @@ scpi {
 		scpi_clocks: clocks {
 			compatible = "arm,scpi-clocks";
 
-			scpi_dvfs: scpi_clocks@0 {
+			scpi_dvfs: clock-controller {
 				compatible = "arm,scpi-dvfs-clocks";
 				#clock-cells = <1>;
 				clock-indices = <0>;
-- 
2.39.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node
  2023-01-11 21:13 ` [PATCH v2 1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node Martin Blumenstingl
@ 2023-01-13  7:58   ` neil.armstrong
  0 siblings, 0 replies; 15+ messages in thread
From: neil.armstrong @ 2023-01-13  7:58 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Vyacheslav Bocharov

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Unit addresses should be written using lower-case hex characters. Use
> wifi_mac@c to fix a yaml schema validation error once the eFuse
> dt-bindings have been converted to a yaml schema:
>    efuse: Unevaluated properties are not allowed ('wifi_mac@C' was
>    unexpected)
> 
> Also node names should use hyphens instead of underscores as the latter
> can also cause warnings.
> 
> Fixes: abfaae24ecf3 ("arm64: dts: meson-gxl: add support for JetHub H1")
> Acked-by: Vyacheslav Bocharov <adeep@lexina.in>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> changes from v1 -> v2:
> - Added Vyacheslav's Acked-by (originally given as "Vyachesav", but my
>    understanding is that this was a typo
> - Also replace the underscore in the node name with a hyphen
> 
>   .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts     | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
> index 6831137c5c10..270483e007bc 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
> @@ -90,7 +90,7 @@ bt_mac: bt_mac@6 {
>   		reg = <0x6 0x6>;
>   	};
>   
> -	wifi_mac: wifi_mac@C {
> +	wifi_mac: wifi-mac@c {
>   		reg = <0xc 0x6>;
>   	};
>   };

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 2/6] arm64: dts: meson-gxl: jethub-j80: Fix Bluetooth MAC node name
  2023-01-11 21:13 ` [PATCH v2 2/6] arm64: dts: meson-gxl: jethub-j80: Fix Bluetooth MAC node name Martin Blumenstingl
@ 2023-01-13  7:58   ` neil.armstrong
  0 siblings, 0 replies; 15+ messages in thread
From: neil.armstrong @ 2023-01-13  7:58 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Vyacheslav Bocharov

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Node names should use hyphens instead of underscores to not cause
> warnings.
> 
> Fixes: abfaae24ecf3 ("arm64: dts: meson-gxl: add support for JetHub H1")
> Suggested-by: Vyacheslav Bocharov <adeep@lexina.in>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> changes from v1 -> v2:
> - new patch
> 
>   .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts     | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
> index 270483e007bc..bb7412070cb2 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
> @@ -86,7 +86,7 @@ sdio_pwrseq: sdio-pwrseq {
>   };
>   
>   &efuse {
> -	bt_mac: bt_mac@6 {
> +	bt_mac: bt-mac@6 {
>   		reg = <0x6 0x6>;
>   	};
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 3/6] arm64: dts: meson-axg: jethub-j1xx: Fix MAC address node names
  2023-01-11 21:13 ` [PATCH v2 3/6] arm64: dts: meson-axg: jethub-j1xx: Fix MAC address node names Martin Blumenstingl
@ 2023-01-13  7:59   ` neil.armstrong
  0 siblings, 0 replies; 15+ messages in thread
From: neil.armstrong @ 2023-01-13  7:59 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Node names should use hyphens instead of underscores to not cause
> warnings.
> 
> Fixes: 59ec069d5055 ("arm64: dts: meson-axg: add support for JetHub D1p (j110)")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> changes from v1 -> v2:
> - new patch
> 
>   .../boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi     | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
> index 5836b0030931..22fd43b5fd73 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
> @@ -168,15 +168,15 @@ sn: sn@32 {
>   		reg = <0x32 0x20>;
>   	};
>   
> -	eth_mac: eth_mac@0 {
> +	eth_mac: eth-mac@0 {
>   		reg = <0x0 0x6>;
>   	};
>   
> -	bt_mac: bt_mac@6 {
> +	bt_mac: bt-mac@6 {
>   		reg = <0x6 0x6>;
>   	};
>   
> -	wifi_mac: wifi_mac@c {
> +	wifi_mac: wifi-mac@c {
>   		reg = <0xc 0x6>;
>   	};
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name
  2023-01-11 21:13 ` [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name Martin Blumenstingl
@ 2023-01-13  7:59   ` neil.armstrong
  2023-01-13  7:59   ` neil.armstrong
  1 sibling, 0 replies; 15+ messages in thread
From: neil.armstrong @ 2023-01-13  7:59 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Vyacheslav Bocharov

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Unit names should use hyphens instead of underscores to not cause
> warnings.
> 
> Fixes: bfe59f92d306 ("ARM64: dts: amlogic: gxbb: Enable NVMEM")
> Suggested-by: Vyacheslav Bocharov <adeep@lexina.in>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> changes from v1 -> v2:
> - new patch
> 
>   arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index e3c12e0be99d..f8b115cd6775 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -233,7 +233,7 @@ sn: sn@14 {
>   			reg = <0x14 0x10>;
>   		};
>   
> -		eth_mac: eth_mac@34 {
> +		eth_mac: eth-mac@34 {
>   			reg = <0x34 0x10>;
>   		};
>   


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name
  2023-01-11 21:13 ` [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name Martin Blumenstingl
  2023-01-13  7:59   ` neil.armstrong
@ 2023-01-13  7:59   ` neil.armstrong
  1 sibling, 0 replies; 15+ messages in thread
From: neil.armstrong @ 2023-01-13  7:59 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree, Vyacheslav Bocharov

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Unit names should use hyphens instead of underscores to not cause
> warnings.
> 
> Fixes: bfe59f92d306 ("ARM64: dts: amlogic: gxbb: Enable NVMEM")
> Suggested-by: Vyacheslav Bocharov <adeep@lexina.in>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> changes from v1 -> v2:
> - new patch
> 
>   arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index e3c12e0be99d..f8b115cd6775 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -233,7 +233,7 @@ sn: sn@14 {
>   			reg = <0x14 0x10>;
>   		};
>   
> -		eth_mac: eth_mac@34 {
> +		eth_mac: eth-mac@34 {
>   			reg = <0x34 0x10>;
>   		};
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 5/6] arm64: dts: meson-g12a: Fix internal Ethernet PHY unit name
  2023-01-11 21:13 ` [PATCH v2 5/6] arm64: dts: meson-g12a: Fix internal Ethernet PHY " Martin Blumenstingl
@ 2023-01-13  7:59   ` neil.armstrong
  0 siblings, 0 replies; 15+ messages in thread
From: neil.armstrong @ 2023-01-13  7:59 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Documentation/devicetree/bindings/net/ethernet-phy.yaml defines that the
> node name for Ethernet PHYs should match the following pattern:
>    ^ethernet-phy(@[a-f0-9]+)?$
> 
> Replace the underscore with a hyphen to adhere to this binding.
> 
> Fixes: 280c17df8fbf ("arm64: dts: meson: g12a: add mdio multiplexer")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> changes from v1 -> v2:
> - new patch
> 
>   arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 9dbd50820b1c..c95cf3afc666 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -1694,7 +1694,7 @@ int_mdio: mdio@1 {
>   					#address-cells = <1>;
>   					#size-cells = <0>;
>   
> -					internal_ephy: ethernet_phy@8 {
> +					internal_ephy: ethernet-phy@8 {
>   						compatible = "ethernet-phy-id0180.3301",
>   							     "ethernet-phy-ieee802.3-c22";
>   						interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address
  2023-01-11 21:13 ` [PATCH v2 6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address Martin Blumenstingl
@ 2023-01-13  7:59   ` neil.armstrong
  0 siblings, 0 replies; 15+ messages in thread
From: neil.armstrong @ 2023-01-13  7:59 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, khilman, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Node names should be generic and use hyphens instead of underscores to
> not cause warnings. Also nodes without a reg property should not have a
> unit-address. Change the scpi_dvfs node to use clock-controller as node
> name without a unit address (since it does not have a reg property).
> 
> Fixes: 70db166a2baa ("ARM64: dts: meson-gxbb: Add SCPI with cpufreq & sensors Nodes")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> changes from v1 -> v2:
> - new patch
> 
>   arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index f8b115cd6775..a79a35e84281 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -250,7 +250,7 @@ scpi {
>   		scpi_clocks: clocks {
>   			compatible = "arm,scpi-clocks";
>   
> -			scpi_dvfs: scpi_clocks@0 {
> +			scpi_dvfs: clock-controller {
>   				compatible = "arm,scpi-dvfs-clocks";
>   				#clock-cells = <1>;
>   				clock-indices = <0>;

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 0/6] arm64: dts: small .dts fixes
  2023-01-11 21:13 [PATCH v2 0/6] arm64: dts: small .dts fixes Martin Blumenstingl
                   ` (5 preceding siblings ...)
  2023-01-11 21:13 ` [PATCH v2 6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address Martin Blumenstingl
@ 2023-01-13  8:03 ` Neil Armstrong
  6 siblings, 0 replies; 15+ messages in thread
From: Neil Armstrong @ 2023-01-13  8:03 UTC (permalink / raw)
  To: linux-amlogic, Martin Blumenstingl
  Cc: linux-arm-kernel, linux-kernel, khilman, jbrunet,
	krzysztof.kozlowski+dt, robh+dt, devicetree

Hi,

On Wed, 11 Jan 2023 22:13:44 +0100, Martin Blumenstingl wrote:
> This series contains a few .dts fixes which were found during review of
> [0] (which is now the first patch in this series).
> 
> 
> 
> [0] https://lore.kernel.org/linux-amlogic/20230110215926.1296650-1-martin.blumenstingl@googlemail.com/
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.3/arm64-dt)

[1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node
      https://git.kernel.org/amlogic/c/f95acdb2b4af21caae2c76a48e565158181386ca
[2/6] arm64: dts: meson-gxl: jethub-j80: Fix Bluetooth MAC node name
      https://git.kernel.org/amlogic/c/cb199de1d3aecb02556d8a6e26393015effa0a9f
[3/6] arm64: dts: meson-axg: jethub-j1xx: Fix MAC address node names
      https://git.kernel.org/amlogic/c/2f66eeb06e3e8b1cac9e9093be3baadbac2709eb
[4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name
      https://git.kernel.org/amlogic/c/8ed5310356bfa47cc6bb4221ae6b21258c52e3d1
[5/6] arm64: dts: meson-g12a: Fix internal Ethernet PHY unit name
      https://git.kernel.org/amlogic/c/e7303651bbc76c848007f1cfac1fbeaa65f600d1
[6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address
      https://git.kernel.org/amlogic/c/f189c869ad92787ddd753558bcbae89d75825bb6

These changes has been applied on the intermediate git tree [1].

The v6.3/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2023-01-13  8:04 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-11 21:13 [PATCH v2 0/6] arm64: dts: small .dts fixes Martin Blumenstingl
2023-01-11 21:13 ` [PATCH v2 1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node Martin Blumenstingl
2023-01-13  7:58   ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 2/6] arm64: dts: meson-gxl: jethub-j80: Fix Bluetooth MAC node name Martin Blumenstingl
2023-01-13  7:58   ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 3/6] arm64: dts: meson-axg: jethub-j1xx: Fix MAC address node names Martin Blumenstingl
2023-01-13  7:59   ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name Martin Blumenstingl
2023-01-13  7:59   ` neil.armstrong
2023-01-13  7:59   ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 5/6] arm64: dts: meson-g12a: Fix internal Ethernet PHY " Martin Blumenstingl
2023-01-13  7:59   ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address Martin Blumenstingl
2023-01-13  7:59   ` neil.armstrong
2023-01-13  8:03 ` [PATCH v2 0/6] arm64: dts: small .dts fixes Neil Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®