From: John Garry <john.g.garry@oracle.com>
To: xiaopeitux@foxmail.com
Cc: andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org,
robh@kernel.org, xiaopei01@kylinos.cn, xuwei5@hisilicon.com
Subject: Re: [PATCH 2/3 V1] lib: logic_pio: export function symbol in logic_pio
Date: Tue, 22 Apr 2025 17:05:48 +0100 [thread overview]
Message-ID: <0502a9cd-d13a-4de0-bc86-3ae0466695f5@oracle.com> (raw)
In-Reply-To: <tencent_2BC43E7712D51EA49597D8C9DE5CAE2B5906@qq.com>
On 22/04/2025 12:31, xiaopeitux@foxmail.com wrote:
> From: Pei Xiao<xiaopei01@kylinos.cn>
>
> export some function via EXPORT_SYMBOL, convenient to use in
> kernel modules in the future if somebody went to use this lib.
> This is one reason for this library exists.
>
> Signed-off-by: Pei Xiao<xiaopei01@kylinos.cn>
No, we don't export just because someone might need this is future.
And, FWIW, EXPORT_SYMBOL_GPL is preferred.
next prev parent reply other threads:[~2025-04-22 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1745320689.git.xiaopei01@kylinos.cn>
2025-04-22 11:31 ` [PATCH 1/3 V2] bus: hisi_lpc: remove unused head file in hisi_lpc.c xiaopeitux
2025-04-22 15:47 ` Andy Shevchenko
2025-04-23 3:30 ` Pei Xiao
2025-04-22 11:31 ` [PATCH 2/3 V1] lib: logic_pio: export function symbol in logic_pio xiaopeitux
2025-04-22 15:27 ` Andy Shevchenko
2025-04-22 15:30 ` Andy Shevchenko
2025-04-22 16:05 ` John Garry [this message]
2025-04-23 3:36 ` Pei Xiao
2025-04-23 7:18 ` John Garry
2025-04-22 11:32 ` [PATCH 3/3 V2] lib: logic_pio: Add detailed comments for find_io_range() and logic_pio_trans_cpuaddr() xiaopeitux
2025-04-22 15:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0502a9cd-d13a-4de0-bc86-3ae0466695f5@oracle.com \
--to=john.g.garry@oracle.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=xiaopei01@kylinos.cn \
--cc=xiaopeitux@foxmail.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®